@Simon, couple of small things:
* you should use 8.0-0ubuntu3.1 as the version instead of 8.0-0ubuntu4
* the changelog has a date of 'Tue, 17 May 2016 17:59:58 +0200' which is quite 
old, yet the diff was only recently uploaded. You can use 'dch -r' to update 
the date

More importantly:
 * the patch introduces compiler warnings. These should be cleaned up:
+modules/module-snappy-policy.c: In function ‘connect_record_hook’:
+modules/module-snappy-policy.c:57:5: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
+     char *label = NULL;
+     ^
+modules/module-snappy-policy.c:65:5: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
+     pa_hook_result_t decision = PA_HOOK_OK;
+     ^


* configure shows:
+    Enable Snappy support:         no
+    Enable Apparmor:               yes

Can you comment on why snappy support was added to configure in this
patch if you aren't going to use it? It seems that snappy support is
compiled though, cause I see '-DHAVE_SNAPPY=1' in the build logs and see
usr/lib/pulse-8.0/modules/module-snappy-policy.so is now shipped.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1583057

Title:
  Deny audio recording for all snap applications

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1583057/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to