** Also affects: ubiquity (Ubuntu Trusty) Importance: Undecided Status: New
** Also affects: ubiquity (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: ubiquity (Ubuntu) Status: Confirmed => Fix Released ** Changed in: ubiquity (Ubuntu Trusty) Importance: Undecided => Medium ** Changed in: ubiquity (Ubuntu Xenial) Importance: Undecided => Medium ** Changed in: ubiquity (Ubuntu Trusty) Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox) ** Changed in: ubiquity (Ubuntu Xenial) Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox) ** Changed in: ubiquity (Ubuntu Trusty) Status: New => In Progress ** Changed in: ubiquity (Ubuntu Xenial) Status: New => In Progress ** Description changed: + [Impact] + Users with NVMe disks. + + [Test case] + - Install system with NVMe disks; expect to pick the boot device. + Install should complete succesfully. + + [Regression Potential] + None, this only adds matching for NVMe devices; any such devices will now be matched based on the partition numbers rather than risking to match a character device for NVMe formatting. This does not match regular block devices and partitions. + + --- + On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity fails to install grub. In ubiquity/misc.py the function default_grub targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of the device. For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line: old: target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*', r'\1', target) fixed: target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*', r'\1', target) ** Description changed: [Impact] Users with NVMe disks. [Test case] - Install system with NVMe disks; expect to pick the boot device. Install should complete succesfully. [Regression Potential] - None, this only adds matching for NVMe devices; any such devices will now be matched based on the partition numbers rather than risking to match a character device for NVMe formatting. This does not match regular block devices and partitions. + This only adds matching for NVMe devices; any such devices will now be matched based on the partition numbers rather than risking to match a character device for NVMe formatting. This does not match regular block devices and partitions. --- On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity fails to install grub. In ubiquity/misc.py the function default_grub targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of the device. For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line: old: target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*', r'\1', target) fixed: target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*', r'\1', target) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1600308 Title: ubiquity targets invalid device name with nvme disks, fails to install grub To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1600308/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs