Thanks Joseph. 
In the meantime, I finished the bisect. It tells me the following commit is to 
blame:

87bd13c6f9776e18ab9a5192325c54621db8a2af is the first bad commit
commit 87bd13c6f9776e18ab9a5192325c54621db8a2af
Author: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>
Date:   Mon Jun 27 07:10:51 2016 -0600

    tpm_crb: fix mapping of the buffers
    
    BugLink: http://bugs.launchpad.net/bugs/1596469
    
    On my Lenovo x250 the following situation occurs:
    
    [18697.813871] tpm_crb MSFT0101:00: can't request region for resource
    [mem 0xacdff080-0xacdfffff]
    
    The mapping of the control area overlaps the mapping of the command
    buffer. The control area is mapped over page, which is not right. It
    should mapped over sizeof(struct crb_control_area).
    
    Fixing this issue unmasks another issue. Command and response buffers
    can overlap and they do interleave on this machine. According to the PTP
    specification the overlapping means that they are mapped to the same
    buffer.
    
    The commit has been also on a Haswell NUC where things worked before
    applying this fix so that the both code paths for response buffer
    initialization are tested.
    
    Cc: sta...@vger.kernel.org
    Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource")
    Signed-off-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>
    Reviewed-by: Jason Gunthorpe <jguntho...@obsidianresearch.com>
    (cherry picked from linux-next commit 
0af6e0a2da2e4fedaa2743333da438d3b879192b)
    Signed-off-by: Tim Gardner <tim.gard...@canonical.com>
    Acked-by: Stefan Bader <stefan.ba...@canonical.com>
    Acked-by: Brad Figg <brad.f...@canonical.com>
    Signed-off-by: Kamal Mostafa <ka...@canonical.com>                          
                                                                 
                                                                                
                                                                 
:040000 040000 84dfc36e75e151c51541109acdf6dc2a7a620398 
a236ec06194abc467c852316b1b50f3b3a9ae7f0 M      drivers

That also leads me to try a workaround. When I blacklist the tpm_crb
module, I can suspend to my hearts delight. Or at least, more than two
times in a row ;)

** Tags added: bisect-done tpm workaround

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1620089

Title:
  REGRESSION: Laptop hangs during second time it suspends

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1620089/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to