Reviewing the patch from bug 554009, I have the following comments: - as the patch sets SWAPTYPE, no need to set it in line 24 of the original script immediately before the patch: just run wait-for-root (if that is actually needed);
- the test for $resume_offset would be safer if it looked for a number, eg: [ "${resume_offset}" -ge 0] 2>/dev/null - lines 63-67 of the original script can be replaced by line 64 only: no need for a separate resume_offset case. I confirm that the patch enables hibernation and hybrid-sleep to a /swapfile using uswsusp with LXLE 16.04 identifying as "4.4.0-96-generic #119-Ubuntu SMP Tue Sep 12 14:58:51 UTC 2017 i686 i686 i686 GNU/Linux", and also with the above changes. Why is no-one picking this up? Still 3.5 years of support for Ubuntu 16.04 LTS. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1644975 Title: Resume from disk (swapfile) fails To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/initramfs-tools/+bug/1644975/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs