So as mentioned before this has a bit of back and forth, ignoring that the effective changes are: - not renaming, but aliasing to "ua" - fixup and enable tests on build (was requested on a former review) - I checked, the symlinks are good after install - I checked the tests are running fine on build - I verified that the debdiff changes 100% match the git changes they are based on - I don't mind that the changelog has v11/v12 being mostly a revert, that is the "true" changelog, so I agree to keeping it.
>From our IRC discussion I know that you already know that some of this hardly backports for different constraints, so I don't need to mention that - for Bionic and that is important now that LGTM. I'd only have been concerned on the "ua" namespace, but since Steve acked that in c#3 I'm good. Sponsored into Bionic as of now, since the last released version was 10 I built with -v10. @Andreas - please track migration (which might take a while for the dep8 tests to run atm), to trigger the SRUs at the right time. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1721272 Title: Create 'ua' symlink pointing at 'ubuntu-advantage' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
