** Description changed: + [Impact] + Invoking ssh-import-id lp:$missing_user produces unhelpful, noisy error. + + [Test case] + "ssh-import-id lp:mwhudso" should output "no such user" or some similar helpful messsage, not pages of complaints about a file in /tmp not being a public key file. + + [Regression potential] + The upload to bionic unapproved is an untested combination of patches so needs careful testing. Fortunately each patch is small and mostly independent so testing each affected area of code should not be too onerous. + mwhudson@ringil:~/src/ssh-import-id/lp-1770302$ ssh-import-id lp:mwhudso /tmp/ssh-auth-key-check_0bkdmoa.pub is not a public key file. /tmp/ssh-auth-key-checkjxze5tp8.pub is not a public key file. [... continues ...] /tmp/ssh-auth-key-checkqm4_egrs.pub is not a public key file. /tmp/ssh-auth-key-checkn5yqafje.pub is not a public key file. 2018-05-10 15:13:53,539 INFO [0] SSH keys [Authorized] 2018-05-10 15:13:53,543 ERROR No matching keys found for [lp:mwhudso] There is no check of the response status code :(
** Description changed: [Impact] Invoking ssh-import-id lp:$missing_user produces unhelpful, noisy error. + + I want to change subiquity to invoke ssh-import-id directly and helpful + error messages are important in giving useful feedback to the user. [Test case] "ssh-import-id lp:mwhudso" should output "no such user" or some similar helpful messsage, not pages of complaints about a file in /tmp not being a public key file. [Regression potential] The upload to bionic unapproved is an untested combination of patches so needs careful testing. Fortunately each patch is small and mostly independent so testing each affected area of code should not be too onerous. mwhudson@ringil:~/src/ssh-import-id/lp-1770302$ ssh-import-id lp:mwhudso /tmp/ssh-auth-key-check_0bkdmoa.pub is not a public key file. /tmp/ssh-auth-key-checkjxze5tp8.pub is not a public key file. [... continues ...] /tmp/ssh-auth-key-checkqm4_egrs.pub is not a public key file. /tmp/ssh-auth-key-checkn5yqafje.pub is not a public key file. 2018-05-10 15:13:53,539 INFO [0] SSH keys [Authorized] 2018-05-10 15:13:53,543 ERROR No matching keys found for [lp:mwhudso] There is no check of the response status code :( -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1770305 Title: ssh-import-id lp:$missing-user attempts to parse the (HTML) 404 response as a series of ssh keys To manage notifications about this bug go to: https://bugs.launchpad.net/ssh-import-id/+bug/1770305/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs