** Description changed:

+ [Impact]
+ 
+  * Unattended-upgrades does not install upgrades when it is configured
+ to install updates on shutdown and when it the system is started on
+ battery, but installs updates on battery in other cases.
+ 
+  * This behaviour is unintended and confuses users, moreover installing
+ updates on battery risks the system to be shut down in the middle of an
+ upgrade due to depleting the battery.
+ 
+  * This upload changes u-u to skip updates or gracefully stop when the
+ system is switching to batter-powered state by default minimizing the
+ risk of breaking the system.
+ 
+ [Test Case]
+ 
+  * Run "unattended-upgrade --dry-run --verbose" on battery and on AC
+ power
+ 
+  * With default configuration u-u should stop with the following message on 
battery:
+ Initial blacklisted packages: 
+ Initial whitelisted packages: 
+ Starting unattended upgrades script
+ Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, 
o=UbuntuESM,a=bionic
+ System is on battery power, stopping
+ 
+  * On AC power it should continue:
+ $ sudo ./unattended-upgrade --dry-run --verbose
+ Initial blacklisted packages: 
+ Initial whitelisted packages: 
+ Starting unattended upgrades script
+ Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, 
o=UbuntuESM,a=bionic
+ No packages found that can be upgraded unattended and no pending auto-removals
+ 
+  * Add the following configuration file and check u-u continuing even on 
battery:
+ $ cat /etc/apt/apt.conf.d/51unattended-upgrades-on-battery 
+ Unattended-Upgrade::OnlyOnACPower "false";
+ rbalint@yogi:~/projects/deb/unattended-upgrades$ sudo ./unattended-upgrade 
--dry-run --verbose
+ Initial blacklisted packages: 
+ Initial whitelisted packages: 
+ Starting unattended upgrades script
+ Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, 
o=UbuntuESM,a=bionic
+ No packages found that can be upgraded unattended and no pending auto-removals
+ 
+ 
+ [Regression Potential] 
+ 
+  * Unattended-upgrades may fail to install updates even on AC power, but
+ this is unlikely to happen due to the code changed being fairly simple.
+ on_ac_power may return 255 (false) Power status could not be determined,
+ but this is mapped to being on AC power and installing the updates, only
+ subprocess.call("on_ac_power") == 1 makes u-u skip updates.
+ 
+ [Original Bug Text]
+ 
  Ubuntu 17.10 and 18.04 do not install updates with InstallOnShutdown
  flag set.
  
  post-install script on 14.04 and 16.04 would set options in
  /etc/apt/apt.conf.d/50unattended-upgrades and
  /etc/apt/apt.conf.d/10periodic to install updates on shutdown of ubuntu
  desktop. This worked on 17.10 also, until an update before the release
  of 18.04. After a fresh install of 18.04, ran the post install script.
  Below is the contents of the two files, updates do not run, even if
  performing an apt update and leaving the machine up for a few hours to
  download packages in the back ground. Both the unattended-upgrades and
  unattended-upgrades-shutdown log files are empty.
  
  Description:  Ubuntu 18.04 LTS
  Release:      18.04
  
  ii  unattended-upgrades                        1.1ubuntu1
  all          automatic installation of security upgrades
  
- 
  
----------------------/etc/apt/apt.conf.d/50unattended-upgrades----------------
  Unattended-Upgrade::Allowed-Origins {
-         "${distro_id}:${distro_codename}";
-         "${distro_id}:${distro_codename}-security";
-         // Extended Security Maintenance; doesn't necessarily exist for
-         // every release and this system may not have it installed, but if
-         // available, the policy for updates is such that unattended-upgrades
-         // should also install from here by default.
-         "${distro_id}ESM:${distro_codename}";
-         "${distro_id}:${distro_codename}-updates";
+         "${distro_id}:${distro_codename}";
+         "${distro_id}:${distro_codename}-security";
+         // Extended Security Maintenance; doesn't necessarily exist for
+         // every release and this system may not have it installed, but if
+         // available, the policy for updates is such that unattended-upgrades
+         // should also install from here by default.
+         "${distro_id}ESM:${distro_codename}";
+         "${distro_id}:${distro_codename}-updates";
  //      "${distro_id}:${distro_codename}-proposed";
  //      "${distro_id}:${distro_codename}-backports";
-         "LP-PPA-libreoffice:${distro_codename}";
-         "Canonical:${distro_codename}";
+         "LP-PPA-libreoffice:${distro_codename}";
+         "Canonical:${distro_codename}";
  };
  
  Unattended-Upgrade::Package-Blacklist {
  //      "vim";
  //      "libc6";
  //      "libc6-dev";
  //      "libc6-i686";
  };
  
  Unattended-Upgrade::DevRelease "false";
  Unattended-Upgrade::InstallOnShutdown "true";
  Unattended-Upgrade::Remove-Unused-Dependencies "true";
  
- 
  ---------/etc/apt/apt.conf.d/10periodic:----------------------
  APT::Periodic::Update-Package-Lists "1";
  APT::Periodic::Download-Upgradeable-Packages "1";
  APT::Periodic::AutocleanInterval "7";
  APT::Periodic::Unattended-Upgrade "1";

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1773033

Title:
  unattended upgrade no longer actions on shutdown

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1773033/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to