It seems suspicious that cb_data->concheck.curl_ehandle is cleaned up
here despite the comment a few lines above warning that it’s unsafe to
do so.

https://github.com/NetworkManager/NetworkManager/blob/1.12.2/src/nm-
connectivity.c#L190-L213

                /* Contrary to what cURL manual claim it is *not* safe to remove
                 * the easy handle "at any moment"; specifically not from the
                 * write function. Thus here we just dissociate the cb_data from
                 * the easy handle and the easy handle will be cleaned up when 
the
                 * message goes to CURLMSG_DONE in 
_con_curl_check_connectivity(). */
…
                curl_multi_remove_handle (priv->concheck.curl_mhandle, 
cb_data->concheck.curl_ehandle);
                curl_easy_cleanup (cb_data->concheck.curl_ehandle);

This cleanup call was added in
https://github.com/NetworkManager/NetworkManager/pull/70.  The comment
was moved by that PR but was present before.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1792745

Title:
  NetworkManager crashed with SIGSEGV in _int_malloc()

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1792745/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to