There is a mismatch in behaviour of a library function (returns cluster on default port) and what the program expects (null value for port if no cluster was selected)
In some circumstances, (-p specified and older version listening on default port ) this leads to the incorrect binary being run, despite comments in the (program) code saying it should be the most recent binary that is selected. The patch avoids that bug by implementing a TODO: note in the code. My reference to sid was because I saw that some variable names had been changed. I do not currently have a test machine to see which of the 2 versions I have seen is the one in testing. David Sent from my phone. Please excuse any errors On Tue, 9 Oct 2018, 15:01 Robie Basak, <1796...@bugs.launchpad.net> wrote: > Thank you for taking the time to report this bug and helping to make > Ubuntu better. > > Am I right in thinking that your problem is "If a system has a newer > version concurrently installed on a non-default port, then pg_wrapper > fails to automatically select the newer client when -p is specified"? > > I don't see anything in the documentation of pg_wrapper that says it'll > pay attention to -p specified manually. So is this a feature request > (with patch)? > > > NB. the patch will probably not apply cleanly to the current version > in debian/sid > > Please note that we won't update stable releases without first updating > the development release, since otherwise users upgrading to the next > release will subsequently find a regression. If your patch does pass > review etc, it will still be blocked from landing pending a > corresponding patch to the development release. So it's best to start > with testing/fixing the development release, get that landed, and then > backport what is required. > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1796407 > > Title: > patch: make pg_wrapper select correct version for local cluster, based > on port > > To manage notifications about this bug go to: > > https://bugs.launchpad.net/ubuntu/+source/postgresql-common/+bug/1796407/+subscriptions > On 9 Oct 2018 3:01 pm, "Robie Basak" <1796...@bugs.launchpad.net> wrote: Thank you for taking the time to report this bug and helping to make Ubuntu better. Am I right in thinking that your problem is "If a system has a newer version concurrently installed on a non-default port, then pg_wrapper fails to automatically select the newer client when -p is specified"? I don't see anything in the documentation of pg_wrapper that says it'll pay attention to -p specified manually. So is this a feature request (with patch)? > NB. the patch will probably not apply cleanly to the current version in debian/sid Please note that we won't update stable releases without first updating the development release, since otherwise users upgrading to the next release will subsequently find a regression. If your patch does pass review etc, it will still be blocked from landing pending a corresponding patch to the development release. So it's best to start with testing/fixing the development release, get that landed, and then backport what is required. -- You received this bug notification because you are subscribed to the bug report. https://bugs.launchpad.net/bugs/1796407 Title: patch: make pg_wrapper select correct version for local cluster, based on port To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/postgresql-common/+bug/1796407/+subscriptions -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796407 Title: patch: make pg_wrapper select correct version for local cluster, based on port To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/postgresql-common/+bug/1796407/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
