(In reply to Marco Bonardo [::mak] (Away 9-26 Aug) from comment #103) > I made a small sheet to better understand what changes here, please check > and comment if something doesn't look correct. > https://docs.google.com/spreadsheets/d/ > 1VVEVjyIYRZIFteM71j5bJhENa2xXT82gaikr0WgpKLA/edit#gid=0 > > I didn't test the patch, I just assumed, on IRC Gijs said it's likely > different. > Anyway, I added a row with the behavior I'm suggesting, that is pretty much > the same as Chromium, apart ALT+Enter on the Mac.
I think I implemented this in the updated patch, though I left out the support for downloads using 'alt-enter' on mac. I'm not convinced people want that behaviour, and in any case it'd re-introduce per-platform checks and some redundant calls to whereToOpenLink that I'm not super- fond of. Note that the spreadsheet doesn't cover shift-enter, which also canonifies today. I left that as-is, though of course that now also comes under the pref, and can therefore be turned off (at which point we'll open a new window instead). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
