** Description changed: - ubuntu-release-upgrader indicates that - RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that - release upgrades will be attempted without commenting out third party - mirrors or repositories, however in practice this is untrue. This - doesn't work because pkexec is used to call do-release-upgrade, and it - doesn't pass on env, and because sudo (used for DistUpgradeViewText) is - called with -E. This should be sorted out so that the documentation is - not lying and so upgrades with PPAs enabled can be attempted. + Impact + ------ + It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. + + Test Case + --------- + The change is in do-release-upgrade and DistUpgradeController so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. + + 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) + 2) Choose to proceed with the upgrade + + With the version of ubuntu-release-upgrader in the archive you'll + receive a dialog (or message for the text upgrader) saying "No valid + mirror found" and "Do you want to rewrite 'sources.list' anyway?". With + the version of ubuntu-release-upgrader from -proposed you'll receive no + such dialog and you can find "WARNING mirror check skipped" in /var/log + /dist-upgrade/main.log. + + There is no need to complete the full upgrade. + + Regression Potential + -------------------- + + + [Original Description] + ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log /dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config
** Description changed: Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- - The change is in do-release-upgrade and DistUpgradeController so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. + The change is in do-release-upgrade and DistUpgradeFetcherCore.py so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log /dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- - [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log /dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config ** Description changed: Impact ------ It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be. Test Case --------- The change is in do-release-upgrade and DistUpgradeFetcherCore.py so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade. 1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader-gtk (or do-release-upgrade and with -d to upgrade to disco) 2) Choose to proceed with the upgrade With the version of ubuntu-release-upgrader in the archive you'll receive a dialog (or message for the text upgrader) saying "No valid mirror found" and "Do you want to rewrite 'sources.list' anyway?". With the version of ubuntu-release-upgrader from -proposed you'll receive no such dialog and you can find "WARNING mirror check skipped" in /var/log /dist-upgrade/main.log. There is no need to complete the full upgrade. Regression Potential -------------------- + With the pkexec change we are only passing the RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable on to the release upgrade process but with the do-release-upgrade (DistUpgradeFetcherCore.py / sudo) one we are passing all existing environment variables on which could cause an issue for the release upgrade process. [Original Description] ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted. Its possible to confirm the fix for this bug by looking at /var/log /dist-upgrade/main.log for a PPA not being commented out or the following line: 2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via config -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1807032 Title: RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable not passed to dist- upgrader tarball To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1807032/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
