** Description changed: - We have a warning[1] in dmesg shows hns register napi as weight 256 but - not recommended. According to this commit[2] we shall use weight 64 as - suggested. + [Impact] + We have a warning[1] in dmesg shows hns register napi as weight 256 but not recommended. According to this commit[2] we shall use weight 64 as suggested. - To cherry-pick this makes hns driver has reasonable weight + [1] netif_napi_add() called with weight 256 + [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82dc3c63c692b1e1d59378ecee948ac88e034aad + [Test Case] + dmesg | grep netif_napi_add + + [Fix] commit acb1ce15a61154aa501891d67ebf79bc9ea26818 Author: Yonglong Liu <liuyongl...@huawei.com> Date: Thu Apr 4 16:46:43 2019 +0800 net: hns: Use NAPI_POLL_WEIGHT for hns driver When the HNS driver loaded, always have an error print: "netif_napi_add() called with weight 256" This is because the kernel checks the NAPI polling weights requested by drivers and it prints an error message if a driver requests a weight bigger than 64. So use NAPI_POLL_WEIGHT to fix it. Signed-off-by: Yonglong Liu <liuyongl...@huawei.com> Signed-off-by: Peng Li <lipeng...@huawei.com> Signed-off-by: David S. Miller <da...@davemloft.net> - [1] netif_napi_add() called with weight 256 - [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82dc3c63c692b1e1d59378ecee948ac88e034aad + [Regression Risk] + Only weight for NAPI changed. Lowest regression risk.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830587 Title: Reduce NAPI weight in hns driver from 256 to 64 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1830587/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
