Launchpad has imported 20 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1556612.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2019-06-04T03:56:49+00:00 Asif Youssuff wrote: Created attachment 9069563 Screenshot from 2019-06-03 21-33-23.png Steps to reproduce 1. Delete ~/.mozilla/firefox 2. Download build 20190603160429 (not sure it matters if it is after 67, but this is what I used). Add policies.json file to disable updates. 3. Start Firefox 4. Notice profile is "default-release" 5. Create new profile using about:profiles UI, call it "whatever" 6. Quit Firefox 7. Start Firefox 8. Notice profile in use is "whatever", not "default-release" This is Bug 1556603 9. Quit Firefox 10. start Firefox with --safe-mode, start in safe mode 11. Quit Firefox 12. Launch Firefox What happens: Error message saying "You've launched an older version of Firefox" Expected result: No error message, Firefox launches into a profile. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/0 ------------------------------------------------------------------------ On 2019-06-04T16:02:06+00:00 Dtownsend wrote: [Tracking Requested - why for this release]: Users will be blocked from using their profile if they ever use safe- mode. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/1 ------------------------------------------------------------------------ On 2019-06-04T20:40:59+00:00 Dtownsend wrote: Ok, there are a few bugs that combine to cause this behaviour. I have fixes for all of them and while I'm sure of being able to get them into betas I'm less sure of getting them into the next release. So I'm going to attach the simplest fix here that should be perfectly safe to uplift. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/2 ------------------------------------------------------------------------ On 2019-06-04T20:41:28+00:00 Dtownsend wrote: Created attachment 9069765 Bug 1556612: Hardcode considering this an upgrade if the last build to run was run in safe mode. r=froydnj When safe mode runs it writes out "Safe Mode" as the compatibility version (bug 1556831). Due to bug 1556832 and bug 1556829 this makes us think that the next run is a downgrade. This is the simplest possible fix that should be totally safe to upload to release. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/3 ------------------------------------------------------------------------ On 2019-06-04T21:35:55+00:00 Lhenry wrote: Pascal, I figure this should be in the next dot release; marking it as a blocker. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/4 ------------------------------------------------------------------------ On 2019-06-05T15:14:23+00:00 Pascalc wrote: Dave, does this bug only manifests with a policies.json file to block updates? In that case that sounds like it would affect a tiny % of our users and could be included in a future dot release but would not trigger a 67.0.2 ASAP. If you think this is a widespread problem, should we stop updating users to 67.0.1? Thanks Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/5 ------------------------------------------------------------------------ On 2019-06-05T15:31:51+00:00 Dtownsend wrote: (In reply to Pascal Chevrel:pascalc from comment #5) > Dave, does this bug only manifests with a policies.json file to block > updates? In that case that sounds like it would affect a tiny % of our users > and could be included in a future dot release but would not trigger a 67.0.2 > ASAP. If you think this is a widespread problem, should we stop updating > users to 67.0.1? Thanks This bug affects anyone who uses safe mode. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/6 ------------------------------------------------------------------------ On 2019-06-05T15:50:47+00:00 Pascalc wrote: (In reply to Dave Townsend [:mossop] (he/him) from comment #6) > (In reply to Pascal Chevrel:pascalc from comment #5) > > Dave, does this bug only manifests with a policies.json file to block > > updates? In that case that sounds like it would affect a tiny % of our > > users and could be included in a future dot release but would not trigger a > > 67.0.2 ASAP. If you think this is a widespread problem, should we stop > > updating users to 67.0.1? Thanks > > This bug affects anyone who uses safe mode. well, I just launched 67.0.1 in safe mode and it works for me… [EDIT] I can reproduce the bug on linux on the second start in safe mode Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/7 ------------------------------------------------------------------------ On 2019-06-05T16:12:00+00:00 Pascalc wrote: (In reply to Dave Townsend [:mossop] (he/him) from comment #3) > Created attachment 9069765 > Bug 1556612: Hardcode considering this an upgrade if the last build to run > was run in safe mode. r=froydnj > > When safe mode runs it writes out "Safe Mode" as the compatibility version > (bug > 1556831). Due to bug 1556832 and bug 1556829 this makes us think that the next > run is a downgrade. > > This is the simplest possible fix that should be totally safe to upload to > release. Could you request an uplift to release? Thanks Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/8 ------------------------------------------------------------------------ On 2019-06-05T16:18:27+00:00 Pulsebot wrote: Pushed by dtowns...@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d779cd26a8f0 Hardcode considering this an upgrade if the last build to run was run in safe mode. r=froydnj Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/9 ------------------------------------------------------------------------ On 2019-06-05T16:24:15+00:00 Dtownsend wrote: Comment on attachment 9069765 Bug 1556612: Hardcode considering this an upgrade if the last build to run was run in safe mode. r=froydnj ### Beta/Release Uplift Approval Request * **User impact if declined**: After running Firefox in safe mode the next launch of Firefox will tell their user that they have downgraded firefox and without some manual steps the user will be unable to use their profile ever again. * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: No * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: Automated tests cover the code changed but since there are not good full startup tests it would be worth QE verifying this quickly. The steps are: 1. From about:support restart into safe mode. 2. Quit and launch Firefox. Firefox should open without displaying the downgrade dialog. * **List of other uplifts needed**: None * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: This is a minimal change targetted at the specific situation here, there is no risk of it impacting anything else. * **String changes made/needed**: None Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/10 ------------------------------------------------------------------------ On 2019-06-05T21:21:02+00:00 David-sacal wrote: Hi, i've been able to reproduce the bug on Mac Os 10.13 (even on the latest nightly) on my side but not on Windows10 nor on nightly or release (67.01) using a computer with lots of profiles and also a clean one that never had firefox before. Regards David Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/11 ------------------------------------------------------------------------ On 2019-06-05T22:03:21+00:00 Aiakab-g wrote: https://hg.mozilla.org/mozilla-central/rev/d779cd26a8f0 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/12 ------------------------------------------------------------------------ On 2019-06-05T22:31:16+00:00 Lhenry wrote: Comment on attachment 9069765 Bug 1556612: Hardcode considering this an upgrade if the last build to run was run in safe mode. r=froydnj Let's get this onto m-r so we can start a build for 67.0.2 soon (though we are still going to work on verifying) Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/13 ------------------------------------------------------------------------ On 2019-06-05T22:56:57+00:00 Aiakab-g wrote: https://hg.mozilla.org/releases/mozilla-release/rev/b83af63ec81d Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/14 ------------------------------------------------------------------------ On 2019-06-06T09:15:01+00:00 Julien Cristau wrote: Comment on attachment 9069765 Bug 1556612: Hardcode considering this an upgrade if the last build to run was run in safe mode. r=froydnj approved for 68.0b8 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/15 ------------------------------------------------------------------------ On 2019-06-06T09:50:04+00:00 Bogdan-maris wrote: Reproduced the initial issue using 67.0.1 on macOS 10.13 and Ubuntu 18.04 64bit. Verified that the issue is fixed on 67.0.2 across platforms (macOS 10.13, Ubuntu 18.04 and Windows 10 64bit). I also did some exploratory testing around it to search for potential regressions that might have surfaced but could not find any. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/16 ------------------------------------------------------------------------ On 2019-06-06T10:06:01+00:00 Cbrindusan wrote: https://hg.mozilla.org/releases/mozilla-beta/rev/f78bcf6d473e Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/17 ------------------------------------------------------------------------ On 2019-06-07T15:30:57+00:00 Bogdan-maris wrote: I also verified that the issue is not visible on 68.0b8 and latest 69.0a1 across platforms. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/18 ------------------------------------------------------------------------ On 2019-06-11T07:59:11+00:00 Standard8 wrote: *** Bug 1557921 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1832015/comments/24 ** Changed in: firefox Status: Unknown => Fix Released ** Changed in: firefox Importance: Unknown => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1832015 Title: firefox 67.0.1 lost my profile To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1832015/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
