** Description changed: [SRU] - [Summary] Due to an error in how additions and deletions are processed in desktop management handled by pcmanfm-qt/libfm-qt, the desktop shows the remnants of temporary desktop files. They are non-existent files and are both ugly and infuriating to users. Upstream issued a fix: https://github.com/lxqt/libfm-qt/commit/f944be7d2447d5c579a57fb5519ee5e2dece5871 However, they did not release it. The Debian maintainer (closely tied with upstream development) suggested pulling in all the changes fixed in Debian along with this one since they do not include any new features: https://github.com/lxqt/pcmanfm-qt/issues/944#issuecomment-485274347 The fix was introduced in Debian with 0.14.1-6 and that patch found its way to Ubuntu with the merge in 0.14.1-8ubuntu1 - [Test Case] - 1. Boot to a freshly installed system (Lubuntu is ideal) - 2. Note that desktop shortcuts for Home, Trash, Computer, and Network are all displayed, with no additional files - 3. All paths are clickable both on the desktop and in the file manager - 4. Right click on the desktop - 5. Click on "Desktop Preferences" - 6. Click on the "Advanced" tab - 7. Uncheck "Home" - 8. Click OK - 9. No additional files should show on the desktop + 1. Boot to a freshly installed system (Lubuntu is ideal) + 2. Note that desktop shortcuts for Home, Trash, Computer, and Network are all displayed, with no additional files + 3. All paths are clickable both on the desktop and in the file manager + 4. Right click on the desktop + 5. Click on "Desktop Preferences" + 6. Click on the "Advanced" tab + 7. Uncheck "Home" + 8. Click OK + 9. No additional files should show on the desktop 10. Repeat steps above, but check "Home" again 11. No additional files should show on the desktop 12. Log out and back in again 13. No additional files should show on the desktop 14. Repeat 4-13 with the other shortcuts When the bug would occur, any change to the desktop shortcuts would result in a new temporary file remnant. Additionally, logging out and back in again would further affect it. - [Regression Potential] - The immediate concern is that pcmanfm-qt could require a no-change rebuild, since it is closely tied to libfm-qt. Otherwise the changes, even with the full set in 0.14.1-8ubuntu1 are relatively small: + The immediate concern is that pcmanfm-qt could require a no-change + rebuild, since it is closely tied to libfm-qt. + + Otherwise the changes, even with the full set in 0.14.1-8ubuntu1 are relatively small: https://launchpadlibrarian.net/425152824/libfm-qt_0.14.1-0ubuntu2_0.14.1-8ubuntu1.diff.gz + These changes include the following: + * minor changes to debian/control, most notably the removal of an obsolete Depend/Build-Depend + * changes to the year in debian/copyright + * a completely ineffective change to an debian/install file + * removed obsolete switch in debian/rules + * some additional data in debian/upstream/metadata + * 4 patches: + 1. the fix for this bug + 2. fixing license headers for some libfm code + 3. fixing SMB recursive copy (a useful, albeit unnecessary addition with a relatively small impact as it does not affect all users) + 4. workaround for GLib recursive moving error + + The biggest concerns with this set is the additional patches. The + license headers should not be a particular concern, but the latter two + represent possibility for problems. + + The SMB recursive copy bug is caused because the code tries to preserve + permissions which may not be possible with a Samba share. An error is + emitted, and thus the problem. The code still tries to preserve + permissions and only ignores the error if unsuccessful. It's certainly + possible the copy may fail for some other reason, which could be one + potential source for regression. + + The GLib recursive moving error is perhaps a greater source for regression since it appears that the problem is a little less well understood: + https://github.com/lxqt/pcmanfm-qt/issues/943#issuecomment-485017181 + The solution when the move fails is to ignore the error and copy and delete instead. The only potential for problems is if the copy fails but the delete continues and the delete results in the loss of data. + + As for the fix for this particular bug, there should really be no cause + for regression. One part of the change moves the process of changes to a + later point in the logic, to allow for all changes to accumulate. + Another part is more careful with removing deletions from the queue and + and only does so if the file has been removed. The most important part + for our bug is that a deleted file is not removed from the addition + queue and then ignored in the deletion queue. If anything this code + seeks to take more edge cases into account. --- [Original Description] STEPS TO REPRODUCE 1. Boot to installed system 2. Note that desktop shortcuts for Home, Trash, Computer, and Network are all displayed, along with a user-home.desktop with a 6 digit alphanumeric string appended to it 3. Note that the file does not exist (e.g. with the file manager) 4. Right click on the desktop 5. Click on "Desktop Preferences" 6. Click on the "Advanced" tab 7. Uncheck "Home" 8. Click OK 9. Note that the desktop shortcut for Home and the extra non-existent file disappears but nothing else changes 10. Repeat steps above, but check "Home" again 11. Note that all of the desktop shortcuts are displayed, but also a new file, most likely computer.deskop, but with a 6 digit alphanumeric string appended to it. 12. Note that the file does not exist (e.g. with the file manager) 13. Log out and back in again 14. Note that now there's a user.desktop instead of a computer.desktop EXPECTED RESULTS * non-existent files should not be displayed on the desktop * if shortcuts files are temporarily renamed with the random string appended, they should be recycled when finished ACTUAL RESULTS The shortcuts display correctly, but the additional non-existent file sometimes shows. There is an unambiguous way to reproduce (see below), but it's not consistent: * Lubuntu 19.04 live does not have the problem * Lubuntu 19.04 install boots to the problem * When pcmanfm-qt is restarted in Lubuntu, the errant file goes away, but logging out and back in again returns the problem NOTES Also occurs in Debian testing, though it doesn't initially have the problem and only affects the Home shortcut. WORKAROUND 1. Open pcmanfm-qt 2. Go to the Desktop folder 3. Refresh the folder (F5) Now the errant file will not return, no matter whether or not you check shortcuts on or off. It will return when you log in again, though. We're tracking the ultimate resolution of this in Lubuntu here: https://phab.lubuntu.me/T70 ProblemType: Bug DistroRelease: Ubuntu 19.04 Package: pcmanfm-qt 0.14.1-0ubuntu1 ProcVersionSignature: Ubuntu 5.0.0-13.14-generic 5.0.6 Uname: Linux 5.0.0-13-generic x86_64 ApportVersion: 2.20.10-0ubuntu27 Architecture: amd64 CurrentDesktop: LXQt Date: Fri Apr 19 15:18:20 2019 InstallationDate: Installed on 2019-04-18 (0 days ago) InstallationMedia: Lubuntu 19.04 "Disco Dingo" - Release amd64 (20190416) SourcePackage: pcmanfm-qt UpgradeStatus: No upgrade log present (probably fresh install)
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825587 Title: non-existent temporary desktop file appears on desktop To manage notifications about this bug go to: https://bugs.launchpad.net/lxqt/+bug/1825587/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
