Thanks for the debdiff.

The patch itself looks good to me.

I have a few comments on the changelog entry:
   * I'd add a section about which bugs have been fixed with the merge:
      - Enable net user share (LP: #128548).
   * I'd add a section about dropped patches, with a short version of your 
previous comment 
(https://bugs.launchpad.net/ubuntu/+source/samba/+bug/165072/comments/6).
   * In the panic action script entry, "doesn't bail out..." should be dropped 
as it's no longer in the diff. 
   * In the smb.conf entry, I'd add an entry related to the "passwd chat" 
option.
   * In the control entry, I'd mention the Maintainer field update.

-- 
please merge samba 3.0.27a-1 (main) from Debian unstable (main)
https://bugs.launchpad.net/bugs/165072
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to