Kernel SRU request submitted:
https://lists.ubuntu.com/archives/kernel-team/2020-May/thread.html#109623
Changing status to 'In Progress'.

** Description changed:

+ SRU Justification:
+ ==================
+ 
+ [Impact]
+ 
+ * An issue with the endianess handling in the Mellanox mlx5 driver was
+ found.
+ 
+ * The mask value is provided as 64 bit and has to be casted in either 32
+ or 16 bit.
+ 
+ * On big endian systems the wrong half was casted which resulted in an
+ all zero mask.
+ 
+ [Fix]
+ 
+ * Backport: https://launchpadlibrarian.net/476243025/0001-net-mlx5-fix-
+ endianness-handling-in-pedit-mask.patch
+ 
+ [Test Case]
+ 
+ * An s390x system with RoCE Express 2(.1) system is needed and the
+ driver loaded.
+ 
+ * Check whether the mask value stays zero, or if it also get's non-zero
+ values.
+ 
+ * Functional testing is currently only doable by IBM, since we only have
+ RoCE (1) hardware that uses the mlx4 driver.
+ 
+ [Regression Potential]
+ 
+ * There is regression potential is moderate, since:
+ 
+ * the RoCE 2(.1) cards are pretty new and not very wide spread, yet
+ 
+ * the fix got already upstream accepted with 5.6
+ 
+ * However, at the end the patch modifies Mellanox common code
+ (drivers/net/ethernet/mellanox/mlx5/core/en_tc.c) to make the driver
+ work correctly on s390x.
+ 
+ * but the changes were reviewed, signed off by Mellanox engineers and
+ are very limited.
+ 
+ [Other Info]
+ 
+ * The above backport (patch-file) is based on commit
+ 404402abd5f90aa90a134eb9604b1750c1941529 404402abd5f9 "net/mlx5e: Fix
+ endianness handling in pedit mask" - the backport was needed for getting
+ it applied to focal master-next.
+ 
+ * The commit itself got upstream accepted with kernel v5.6, hence should
+ automatically land in 'gorilla', but since gorilla is still based on
+ 5.4, I'm adding 'G' to this SRU.
+ 
+ __________
+ 
  Issue found in the Mellanox mlx5 device driver:
  
  The mask value is provided as 64 bit and has to be casted in
  either 32 or 16 bit. On big endian systems the wrong half was
  casted which resulted in an all zero mask.
  
  We need to get the upstream commit picked up for the Ubuntu 20.04
  kernel.
  
  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=404402abd5f90aa90a134eb9604b1750c1941529

** Changed in: linux (Ubuntu Focal)
       Status: New => In Progress

** Changed in: linux (Ubuntu)
       Status: New => In Progress

** Changed in: ubuntu-z-systems
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1872726

Title:
  [Ubuntu 20.04] net/mlx5e: Fix endianness handling in pedit mask

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1872726/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to