> https://github.com/systemd/systemd/commit/7d0b26a027118ca063780421cb31c74e9d2664ee
this is fine to include, it's clearly correct (I checked both the upstream kernel as well as wireguard-linux-compat from the ppa, and the param is u16 in both places) I assume you can easily reproduce this, just by configuring a non-zero WireGuardPeer.PersistentKeepalive value? If so, can you update the SRU template [test case] section? That will need to be filled out before the patch can be sru'ed. > https://github.com/systemd/systemd/commit/624a47694cad4c87b2e807c32db656f3e9d679c5 I don't think this is needed, it only changes use of sd_netlink_message_append_data() to sd_netlink_message_append_sockaddr_in() - or _in6() - which aren't included in the bionic version of systemd, and from looking at their upstream addition they don't seem to functionally change anything, just add more checking (and simplify the call params). Unless you can point out what the patch specifically fixes, I think we can leave this patch out. ** Description changed: + [impact] + + systemd-networkd uses incorrect netlink attribute length for wireguard's + persistent keepalive interval, which logs error messages from the + kernel, and may incorrectly set the parameter. + + [test case] + + TBD + + [regression potential] + + this adjusts the length of the specific netlink parameter, so any + regression would likely relate to incorrectly setting the persistent + keepalive interval parameter, or failure to set the parameter. + + [scope] + + this is needed only for Bionic. + + this was fixed upstream in commit + 7d0b26a027118ca063780421cb31c74e9d2664ee which was first included in + v240, so this is fixed in Eoan and later. Xenial does not include + support for wireguard, so this does not apply there. + + [original description] + This morning, our 2 Bionic machine configured with the wireguard's PPA and using systemd-networkd to configure the wireguard tunnel started misbehaving. Why this started just now is unclear ATM but their dmesg was filled with this: validate_nla: 100 callbacks suppressed netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. netlink: 'systemd-network': attribute type 5 has an invalid length. Folks in #systemd mentioned https://github.com/systemd/systemd/issues/11575 which points to 2 commits missing from Bionic's systemd version: https://github.com/systemd/systemd/commit/7d0b26a027118ca063780421cb31c74e9d2664ee https://github.com/systemd/systemd/commit/624a47694cad4c87b2e807c32db656f3e9d679c5 Focal's systemd have the above commits. Would it be possible to backport those 2 commits to Bionic? - Additional information: # uname -a Linux noc-eu1 4.15.0-99-generic #100-Ubuntu SMP Wed Apr 22 20:32:56 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux # apt-cache policy systemd wireguard{,-tools,-dkms} systemd: - Installed: 237-3ubuntu10.39 - Candidate: 237-3ubuntu10.39 - Version table: - *** 237-3ubuntu10.39 500 - 500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages - 100 /var/lib/dpkg/status - 237-3ubuntu10.38 500 - 500 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages - 237-3ubuntu10 500 - 500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages + Installed: 237-3ubuntu10.39 + Candidate: 237-3ubuntu10.39 + Version table: + *** 237-3ubuntu10.39 500 + 500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages + 100 /var/lib/dpkg/status + 237-3ubuntu10.38 500 + 500 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages + 237-3ubuntu10 500 + 500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages wireguard: - Installed: 1.0.20200319-1ubuntu1~18.04 - Candidate: 1.0.20200319-1ubuntu1~18.04 - Version table: - *** 1.0.20200319-1ubuntu1~18.04 500 - 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main amd64 Packages - 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main i386 Packages - 100 /var/lib/dpkg/status + Installed: 1.0.20200319-1ubuntu1~18.04 + Candidate: 1.0.20200319-1ubuntu1~18.04 + Version table: + *** 1.0.20200319-1ubuntu1~18.04 500 + 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main amd64 Packages + 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main i386 Packages + 100 /var/lib/dpkg/status wireguard-tools: - Installed: 1.0.20200319-1ubuntu1~18.04 - Candidate: 1.0.20200319-1ubuntu1~18.04 - Version table: - *** 1.0.20200319-1ubuntu1~18.04 500 - 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main amd64 Packages - 100 /var/lib/dpkg/status + Installed: 1.0.20200319-1ubuntu1~18.04 + Candidate: 1.0.20200319-1ubuntu1~18.04 + Version table: + *** 1.0.20200319-1ubuntu1~18.04 500 + 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main amd64 Packages + 100 /var/lib/dpkg/status wireguard-dkms: - Installed: 1.0.20200429-2~18.04 - Candidate: 1.0.20200429-2~18.04 - Version table: - *** 1.0.20200429-2~18.04 500 - 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main amd64 Packages - 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main i386 Packages - 100 /var/lib/dpkg/status + Installed: 1.0.20200429-2~18.04 + Candidate: 1.0.20200429-2~18.04 + Version table: + *** 1.0.20200429-2~18.04 500 + 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main amd64 Packages + 500 http://ppa.launchpad.net/wireguard/wireguard/ubuntu bionic/main i386 Packages + 100 /var/lib/dpkg/status ** Changed in: systemd (Ubuntu Bionic) Assignee: (unassigned) => Dan Streetman (ddstreet) ** Changed in: systemd (Ubuntu Bionic) Importance: Undecided => Low ** Changed in: systemd (Ubuntu Bionic) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877159 Title: netlink: 'systemd-network': attribute type 5 has an invalid length. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1877159/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
