Some comments on the debdiff:

Use
blkid -s TYPE "$writable_part" -o value
instead of
blkid -s TYPE "$writable_part" | awk '{print $2}' | grep -o '".*"' | tr -d '"'

No need to redirect to >>$LOGFILE in resize_filesystem() which is
already redirected when called. Also, you should not redirect to
/dev/kmsg - I guess that was for debugging purposes.

Is it really necessary to mount the partition to find out the filesystem usage?
"btrfs filesystem show" apparently can work on devices according to [1]. But it 
also looks like btrfs commands are mostly used with mounted systems, so it is 
fine if you want to keep things like that.

Finally, you will need to use copy_exec for btrfs and blkid to the
fixtrtc hook to get them included in the initramfs (although maybe blkid
comes from busybox in this case, not sure).

Otherwise, looks good to me.

[1] https://btrfs.wiki.kernel.org/index.php/Manpage/btrfs-filesystem

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1881074

Title:
  Support btrfs when writable is converted to btrfs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/initramfs-tools-devices/+bug/1881074/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to