Hey! Thanks for preparing the SRU! So I think what Steve meant by rejecting the upload is: 1) The addition of javascript-common is not documented anywhere in the SRU, as this feels like a separate change to the bug being fixed here. 2) Restoring of the pegjs binary in usr/bin also seems like a fix for a separate issue, unrelated to 'Pegjs should not provide nodejs.'.
I think the normal procedure here would be to have separate Ubuntu bugs opened for each of those issues (with a separate rationale and test-case section) and added to the .changes file. I guess one might include all that info in this one bug, with separate sections for each change, but that feels a bit less clean. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880680 Title: [SRU] Pegjs should not provide nodejs. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pegjs/+bug/1880680/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
