> Brad, I'd appreciate your review wrt. your comment in https://bugs.launchpad.net/ubuntu/+source/python-certbot- nginx/+bug/1875471/comments/8 please. AIUI, I'm not breaking python- certbot-apache itself, just its tests, right? In other words, with my proposed fix I'm just moving a test failure from python-certbot to python-certbot-apache?
I think it's even better than that. The change you made to Certbot's tests should have no effect on any other package. The tests for python- certbot-apache should still be broken as described at https://bugs.launchpad.net/ubuntu/+source/python-certbot- apache/+bug/1876934, but this change shouldn't add any new failures there. The concern about this change that I tried to express at https://bugs.launchpad.net/ubuntu/+source/python-certbot- nginx/+bug/1875471/comments/8 is we're deleting unit tests for the class certbot.plugins.common.TLSSNI01 while keeping it around and used in python-certbot-apache including for users at runtime. The test file you modified was previously completely broken though and you fixed it allowing the other tests there to run so in general I think it's an improvement. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1893274 Title: Certbot will stop working for 23,847 users with upcoming Let's Encrypt deprecation To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-certbot/+bug/1893274/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
