> What is the impact of this? It seems to happily install PEP 517
packages as-is.

@Stefano sorry for the delay here. Installing PEP517 packages is fine
without the patch, but building them (building a wheel) is where the
issue comes in.

If you need a concrete example, download the .tar.gz of any project that is 
normally capable of producing wheels, such as 'sampleproject' from pypi 
(https://pypi.org/project/sampleproject/#files).
Activate a fresh virtualenv, untar it the .tar.gz, cd into the project, and run:

  python -m pep517.build --binary --out-dir dist .

Before the patch mentioned above, it will fail with:
ModuleNotFoundError: No module named 'toml'

The .deb's from the SRU above get us a step closer but seem to still
have an issue/traceback (see attachment which includes the commands to
reproduce). It looks to be due to the vendored pytoml being listed in
`lib/python3.8/site-packages/pip/_vendor/__init__.py` in the virtualenv.

Whereas doing similar steps in a ubuntu:20.10 container (and installing
pep517 explicitly in the virtualenv) produces a successful result.

** Attachment added: "reproducer using latest SRU build above"
   
https://bugs.launchpad.net/ubuntu/+source/python-virtualenv/+bug/1880749/+attachment/5462853/+files/pep517.build.out

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1880749

Title:
  Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled
  in venvs

To manage notifications about this bug go to:
https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to