When reviewing the SRU of fwupd and fwupd-signed for Ubuntu 20.10 I
noticed a few things which need addressing before the SRUs can be
accepted.

1) The debian/changelog references bug 1900935 but it is improperly formatted 
('LP:#' vs 'LP: #')
2) That bug is missing SRU information in the bug description
3) "Regression Potential" in some bug descriptions doesn't describe what the 
SRU team is actually looking for i.e. "what could go wrong". For example in bug 
1921539 it sounds like the system could fail to boot if the sbat region isn't 
looked for in the correct spot so that's what I'd expect in "regression 
potential".
4) Bug 1909734 is missing SRU information
5) Bug 1886912 is missing SRU information
6) The SRU exception for fwupd (https://wiki.ubuntu.com/firmware-updates) 
indicates that fwupd "Stay with the same release branch that was launched with 
that release". The upload for Focal does not do this as it 1.4.7 and Focal 
released with 1.3.9. Subsequently, I'll reject the Focal upload.

Once these issues have been addressed feel free to ping me and I'll
review the SRU again.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1921544

Title:
  fwupd 1.2.x, 1.3.x, 1.4.x: vendor-id requirement on LVFS causes
  failures

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1921544/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to