Thanks for taking care of this, Lucas.

I reviewed the patch and have two minor comments:

- Since you're adding a delta to the package, update-maintainer needs to
be run.

- Now that you have an Ubuntu bug number, I think you could add the
"Bug-Ubuntu" DEP-3 header to the patches.

Everything else LGTM to me otherwise.  I have tested the patch locally
and verified that it does indeed fix the FTBFS that happens without it.

The only other comment I have is the fact that the package doesn't have
a dep8/autodep8 test (I tried running it locally and got the "SKIP no
tests in this package" message), so it may be a bit harder to verify
that the functionality stays the same and there are no regressions due
to the SRU.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923108

Title:
  FTBFS against docker 20.10

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-github-fsouza-go-dockerclient/+bug/1923108/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to