** Description changed: [IMPACT] - sosreport networking plugin unconditionally exercise 'ethtool -e. + sosreport networking plugin unconditionally exercise 'ethtool -e'. EEPROM dump collection might hang on specific types of devices, ETHTOOL(8) -e --eeprom-dump Retrieves and prints an EEPROM dump for the specified network device. When raw is enabled, then it dumps the raw EEPROM data to stdout. The length and offset parameters allow dumping certain portions of the EEPROM. Default is to dump the entire EEPROM. [TEST PLAN] * On a xenial system ## Should not execute 'ethtool -e' (Default behaviour) * sosreport -o networking ## Should execute 'ethtool -e'. (Only if sosreport is instructed to do so) * sosreport -o networking --plugin-option networking.eepromdump [WHERE PROBLEM OCCURS] No problem expected. networking plugin will be gated to prevent 'ethtool -e' to be run by default, so that sosreport -o networking will not execute 'ethtool -e' command. On the other end, if one really want to eepromdump, one can use the 'eepromdump' plugin option as follows: sosreport -o networking --plugin-option networking.eepromdump So we are changing the default behaviour, but the former one is still available if *REALLY* needed, and knowing the risk that this can occur. sosreport -a ## Will still execute 'ethtool -e' as it turns all option to 'True'. -a, --alloptions Set all boolean options to True for all enabled plug-ins. Unless one specify the following in /etc/sos.conf: --- [tunables] networking.eepromdump = off --- [OTHER INFORMATION] Upstream fix: https://github.com/sosreport/sos/commit/bc3b7eefa093af150286ad6c345cef6afe282756
** Description changed: [IMPACT] sosreport networking plugin unconditionally exercise 'ethtool -e'. EEPROM dump collection might hang on specific types of devices, ETHTOOL(8) -e --eeprom-dump Retrieves and prints an EEPROM dump for the specified network device. When raw is enabled, then it dumps the raw EEPROM data to stdout. The length and offset parameters allow dumping certain portions of the EEPROM. Default is to dump the entire EEPROM. [TEST PLAN] * On a xenial system ## Should not execute 'ethtool -e' (Default behaviour) * sosreport -o networking ## Should execute 'ethtool -e'. (Only if sosreport is instructed to do so) * sosreport -o networking --plugin-option networking.eepromdump [WHERE PROBLEM OCCURS] No problem expected. networking plugin will be gated to prevent 'ethtool -e' to be run by - default, so that + default, so that 'sosreport -o networking' will now no longer execute + 'ethtool -e' command. - sosreport -o networking will not execute 'ethtool -e' command. - On the other end, if one really want to eepromdump, one can use the 'eepromdump' plugin option as follows: + On the other end, if one really want to eepromdump, one can use the + 'eepromdump' plugin option as follows: sosreport -o networking --plugin-option networking.eepromdump - So we are changing the default behaviour, but the former one is still - available if *REALLY* needed, and knowing the risk that this can occur. + Yes, we are changing the default behaviour for good reasons as it may + produce more harm than good the way it is at the moment, BUT the former + behaviour is still available if *REALLY* needed, and after knowing the + risk that this could occur. - sosreport -a ## Will still execute 'ethtool -e' as it turns all option - to 'True'. + Note: + sosreport -a ## Will still execute 'ethtool -e' as it turns all options to 'True'. -a, --alloptions Set all boolean options to True for all enabled plug-ins. Unless one specify the following in /etc/sos.conf: --- [tunables] networking.eepromdump = off --- + so 'sosreport -a' with a combination of adding the right tunables in + /etc/sos.conf will prevent 'ethtool_e' to be executed. + [OTHER INFORMATION] Upstream fix: https://github.com/sosreport/sos/commit/bc3b7eefa093af150286ad6c345cef6afe282756 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1925351 Title: [networking] dpdk port flapping observed during sosreport execution To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sosreport/+bug/1925351/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
