** Description changed:

+ SRU justification (created by Tj)
+ 
+ [Impact]
+ 
+ Without this patch `speedtest-cli` is unable to download the list of
+ servers it needs to fetch each time it is invoked and causes a Python
+ exception and terminates, rendering the tool unusable.
+ 
+ Applying the upstream fix (commit cadc68b5aef20) and backporting it
+ enables the tool to function as intended.
+ 
+ The fix handles the case where `ignoreids` is empty or contains empty
+ ids.
+ 
+ [Test Plan]
+ 
+ Reproduce:
+ 
+ $ speedtest-cli
+ Retrieving speedtest.net configuration...
+ Traceback (most recent call last):
+   File "/usr/bin/speedtest-cli", line 11, in <module>
+     load_entry_point('speedtest-cli==2.1.2', 'console_scripts', 
'speedtest-cli')()
+   File "/usr/lib/python3/dist-packages/speedtest.py", line 1986, in main
+     shell()
+   File "/usr/lib/python3/dist-packages/speedtest.py", line 1872, in shell
+     speedtest = Speedtest(
+   File "/usr/lib/python3/dist-packages/speedtest.py", line 1091, in __init__
+     self.get_config()
+   File "/usr/lib/python3/dist-packages/speedtest.py", line 1173, in get_config
+     ignore_servers = list(
+ ValueError: invalid literal for int() with base 10: ''
+ 
+ After applying the fix:
+ 
+ $ speedtest-cli
+ Retrieving speedtest.net configuration...
+ Testing from Starlink (176.116.125.19)...
+ Retrieving speedtest.net server list...
+ Selecting best server based on ping...
+ Hosted by toob Ltd (London) [2.56 km]: 42.699 ms
+ Testing download 
speed................................................................................
+ Download: 222.97 Mbit/s
+ Testing upload 
speed................................................................................................
+ Upload: 41.19 Mbit/s
+ 
+ [Where problems could occur]
+ 
+ Unlikely this can cause any unwanted reaction.
+ 
+ ------------
+ 
  I just tried to run speedtest-cli and it crashed.
  
  ProblemType: Crash
  DistroRelease: Ubuntu 21.04
  Package: speedtest-cli 2.1.2-2
  ProcVersionSignature: Ubuntu 5.11.0-13.14-generic 5.11.7
  Uname: Linux 5.11.0-13-generic x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair nvidia_modeset 
nvidia
  ApportVersion: 2.20.11-0ubuntu62
  Architecture: amd64
  CurrentDesktop: X-Cinnamon
  Date: Sun Apr 11 05:52:59 2021
  ExecutablePath: /usr/bin/speedtest-cli
  InstallationDate: Installed on 2018-08-10 (974 days ago)
  InstallationMedia: Ubuntu-Server 18.04.1 LTS "Bionic Beaver" - Release amd64 
(20180725)
  InterpreterPath: /usr/bin/python3.9
  PackageArchitecture: all
  ProcCmdline: /usr/bin/python3 /usr/bin/speedtest-cli
  Python3Details: /usr/bin/python3.9, Python 3.9.4, python3-minimal, 3.9.2-2
  PythonArgs: ['/usr/bin/speedtest-cli']
  PythonDetails: N/A
  SourcePackage: speedtest-cli
  Title: speedtest-cli crashed with ValueError in get_config(): invalid literal 
for int() with base 10: ''
  UpgradeStatus: Upgraded to hirsute on 2021-04-11 (0 days ago)
  UserGroups: adm cdrom dip kvm libvirt lpadmin lxd plugdev sambashare sbuild 
sudo

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923352

Title:
  speedtest-cli crashed with ValueError in get_config(): invalid literal
  for int() with base 10: ''

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/speedtest-cli/+bug/1923352/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to