+ case EROFS: + ignore_failure = true; + xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):"")); + break; default: xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):"")); break;
Instead of reproducing the xwarn() call, I believe this should be: + case EROFS: + ignore_failure = true; default: xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):"")); break; I would prefer to see this reconciled before proceeding with the SRU. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1903351 Title: ignore_eacces and ignore_erofs patches don't work properly To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/procps/+bug/1903351/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs