** Description changed: + Test Case + --------- + 1) On an Ubuntu 20.10 system which does not have /sys/class/dmi run do-release-upgrade + 2) Observe a message saying that release upgrades are not allowed + + With the version of the release upgrader from -proposed upgrades will be + allowed. + + Regression Test Cases + -------------------- + This test is to ensure that the quirk for bug 1929449 still works + 1) On Apple hardware running Ubuntu 20.10 run do-release-upgrade -p + 2) Observe a message regarding upgrades not being enabled for Apple hardware and the upgrade exit + + + Regression Potential + -------------------- + Its possible that the quirk won't run any more on Apple hardware but we've created a separate test case for that to ensure that it is still working. Additionally, a check has been added to see if '/sys/firmware/efi' exists before running the quirk. Testing that is covered by the regression test case. + + + Original Description + -------------------- v 1:20.10.16 DistUpgradeQuirks.py, in _test_and_fail_on_apple fails if _readDMIVendor() returns null i.e. if /sys/class/dmi/id/sys_vendor is unknown. However, this is a very common case - it means almost all non-x86 hardware and many VMs (including my test case, WSL2 20.10 -> 21.04) cannot at the time of writing currently upgrade to 21.04. This was noted in "Where problems could occur" on https://bugs.launchpad.net/ubuntu/+source/ubuntu-release- upgrader/+bug/1929449 where the root cause of this bug was introduced, but seems to have been an intentional emergency 'safe' choice while the shim bug is fixed. This emergency patch has been in place for 2 weeks now, blocking updates, however the shim-signed bug appears to be fixed now but the quirk is still in place - perhaps the "system vendor is unknown" check should be removed for now, and once verified the quirk removed altogether?
** Description changed: Test Case --------- 1) On an Ubuntu 20.10 system which does not have /sys/class/dmi run do-release-upgrade 2) Observe a message saying that release upgrades are not allowed With the version of the release upgrader from -proposed upgrades will be allowed. - Regression Test Cases + Regression Test Case -------------------- This test is to ensure that the quirk for bug 1929449 still works 1) On Apple hardware running Ubuntu 20.10 run do-release-upgrade -p 2) Observe a message regarding upgrades not being enabled for Apple hardware and the upgrade exit - Regression Potential -------------------- Its possible that the quirk won't run any more on Apple hardware but we've created a separate test case for that to ensure that it is still working. Additionally, a check has been added to see if '/sys/firmware/efi' exists before running the quirk. Testing that is covered by the regression test case. - Original Description -------------------- v 1:20.10.16 DistUpgradeQuirks.py, in _test_and_fail_on_apple fails if _readDMIVendor() returns null i.e. if /sys/class/dmi/id/sys_vendor is unknown. However, this is a very common case - it means almost all non-x86 hardware and many VMs (including my test case, WSL2 20.10 -> 21.04) cannot at the time of writing currently upgrade to 21.04. This was noted in "Where problems could occur" on https://bugs.launchpad.net/ubuntu/+source/ubuntu-release- upgrader/+bug/1929449 where the root cause of this bug was introduced, but seems to have been an intentional emergency 'safe' choice while the shim bug is fixed. This emergency patch has been in place for 2 weeks now, blocking updates, however the shim-signed bug appears to be fixed now but the quirk is still in place - perhaps the "system vendor is unknown" check should be removed for now, and once verified the quirk removed altogether? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1931112 Title: Apple vendor quirk check for LP#1928434 incorrectly fails on all non- DMI hardware To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1931112/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
