On 2021-09-08 16:54, Heather Ellsworth wrote: > @Gunnar, Thanks! I didn't realize that the 4.6 that debian pulled > fixes the issue. There was nothing in the 4.6 commits that suggested > this issue had been fixed, so did you just build and test it to see? > Or how did you know that 4.6 fixes the issue?
First and foremost I noticed that gnucash 1:4.6-1 built on Debian with version 2.68 of glib2.0. Also, the "Bug 798156 - glib 2.68.0 breaks gnucash" commit predates the upstream 4.6 release. So I didn't build/test myself. > https://salsa.debian.org/debian/gnucash/-/compare/f9461670c5f516e31631a80975eebf6b6e56a1c6...c45dcd6db80fc45ef60cc5d30eb5612f6b64ce9d The master branch of the gnucash repo seems to only include the debian/ directory, not the upstream files. > I don't doubt you at all, just trying to figure out what I missed :) Sure, n.p. > Also, this creating of a patch worked 2 months ago to get past the > build issue.. Well, the "Bug 798156 - glib 2.68.0 breaks gnucash" patch never was sufficient on top of version 4.4 of gnucash. It didn't even apply without first applying a bunch of other commits. Probably it makes a difference on top of version 4.5, though. What you put in your Debian MR seems to be the same as in your PPA. Neither of them changes anything in substance. So it appears you never built with that patch before submitting your MR. Compare your MR with the equivalent patch I included in the fix to understand what I'm talking about. > But, why not put all of the patches into one big patch? In addition to Brian's comment on that, I can say that the fix is the result of some trial and error. Concatenating the patches would have been additional work. :/ TBH I fear that there would have been a much simpler solution: https://gitlab.gnome.org/GNOME/glib/-/issues/2331#note_1067322 But I saw that comment only when the fix was working, and now I'm disinclined to try it with the risk to find out that the work I did was wasted... ** Bug watch added: gitlab.gnome.org/GNOME/glib/-/issues #2331 https://gitlab.gnome.org/GNOME/glib/-/issues/2331 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1923642 Title: glib can no longer be included in extern "C" blocks To manage notifications about this bug go to: https://bugs.launchpad.net/gnucash/+bug/1923642/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
