is there any risk here that enumerating the users, in environments where a large number of users are visible to the system (AD realms, etc), will cause all user creation to be slow here? I would normally expect either to do a try and then catch whatever exception is raised when trying to create an already-existing user, or else to query for the exact username from the backend to find out whether it exists rather than enumerating. (Basically, one of the two options already listed in https://github.com/linuxmint/cinnamon/issues/9494#issue-667846043.) I see that this is already committed upstream, but I still have reservations about making a change such as this in SRU because of the risk that making a change that fixes behavior when the user has made an uncommon error (conflicting username) could impact all users in certain environments (AD realms) that haven't committed an error.
** Bug watch added: github.com/linuxmint/cinnamon/issues #9494 https://github.com/linuxmint/cinnamon/issues/9494 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
