Thank you for this very clean MIR request.
TODO: MIR team ACK, pending clarification of the testing situation.
I understand that proper testing is a 22.04 item, but we should at
least have an example from the current local testing to feel confident
that this will be fully in place before 22.04 completion.
[Summary]
This is a rather small and self-contained script to set up a mock environment
for running the installer snap inside WSL. I do not have big security concerns,
although it needs to be run as root. But please provide some more evidence
around the testing story (e.g. what is the URL of the CI that those tests will
be run? is there already a tests script available? are there any test logs
available?). Also please double check your libexec install location
(usr/lib/libexec VS usr/libexec).
This does NOT need a security review
List of specific binary packages to be promoted to main: wsl-setup
Notes: NONE
Required TODOs:
- Please provide the location/logs/script for the described CI testing
Recommended TODOs:
- The package should get a team bug subscriber before being promoted
- Check lintian (pedantic) notice about libexec location
[Duplication]
There is no other package in main providing the same functionality.
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- checked with check-mir
- not listed in seeded-in-ubuntu
- none of the built reverse-depends are in universe
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now?
Problems: NONE
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries
- not a go package, no extra constraints to consider in that regard
Problems: NONE
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
Problems: NONE
[Common blockers]
OK:
- does not FTBFS currently
- no new python2 dependency
Problems:
- does NOT have a test suite that runs at build time
- does NOT have a non-trivial test suite that runs as autopkgtest
- if special HW does prevent build/autopkgtest is there a test plan, code,
log provided?
=> Planned as 22.04 LTS roadmap item, CI executing the Windows launcher that
will chain into this script, which will itself chain to the installer snap
=> CI script and/or logs should be provided
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is not present – Not needed (native)
- Debian/Ubuntu update history is (good/slow/sporadic)
=> cannot be assessed, as this is a new package
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- d/rules is rather clean
- It is not on the lto-disabled list
Problems:
- Lintian: "P: wsl-setup: executable-in-usr-lib usr/lib/libexec/wsl-setup"
=> shouldn't this rather be in /usr/libexec?
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?
Problems: NONE
** Changed in: wsl-setup (Ubuntu)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1948392
Title:
[MIR] wsl-setup
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wsl-setup/+bug/1948392/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
