** Description changed:

  [Impact]
  With 4.15 kernel, not all binary files inside a subtest directory in
  tools/testing/selftests of a kernel tree can be built with command:
  
-     make TARGETS=$subtest
+     make TARGETS=$subtest
  
  For example, the following binaries in net directory won't be built:
-  * reuseport_bpf
-  * reuseport_bpf_cpu
-  * reuseport_dualstack
-  * reuseaddr_conflict
-  * reuseport_bpf_numa
+  * reuseport_bpf
+  * reuseport_bpf_cpu
+  * reuseport_dualstack
+  * reuseaddr_conflict
+  * reuseport_bpf_numa
  
  They can only be build with:
  
-     make TARGETS=net run_tests
+     make TARGETS=net run_tests
  
  However, this will also start all of the tests in this subset and it's
  is not ideal for the granularity improvement, in which we will want to
  run tests one-by-one.
  
  [Fix]
  1. 14f1889f selftests: Fix loss of test output in run_kselftests.sh
  2. 44f01352 selftests: Makefile set KSFT_TAP_LEVEL to prevent nested TAP 
headers
  3. 8ce72dc3 selftests: fix headers_install circular dependency
  4. 27d79a2b selftests: fix bpf build/test workflow regression when 
KBUILD_OUTPUT is set
  5. e2e88325 selftests: vm: Fix test build failure when built by itself
  
- The 2nd needs to be backported with some context adjustment.
- The 3rd and 4th patch would need to be applied with -C2, the other two
- can be cherry-picked for Bionic.
+ The 1st and 5th patch can be cherry-picked. The 2nd needs to be
+ backported with some context adjustment (can be applied with git -cp
+ but not git am -C2). The 3rd and 4th patch would need to be applied
+ with -C2.
  
- The third patch (8ce72dc3) is the fix for this issue. The 4th
- (27d79a2b) and the 5th (e2e88325) patches are included here as they
- have been marked as a fix for 8ce72dc3.
+ The third patch (8ce72dc3) is the fix for this issue. To get it
+ applied more easily we will need the first two.
+ 
+ The 4th (27d79a2b) and the 5th (e2e88325) patches are included here as
+ they have been marked as a fix for 8ce72dc3. Since we don't use
+ KBUILD_OUTPUT and the vm test, I think the risk of adding these two is
+ pretty low.
  
  [Test]
  Tested on a baremetal node "glameow" with 4.15.0-159-generic, the test
  cases number and results are identical before and after applying this
  change (compared side-by-side).
  
  Please find attachment in the bug report for the test result.
  
  [Where problems could occur]
  As this is just tested with generic Bionic 4.15 kernel on a bare-metal
  system, it's is possible to see other issues on different variants. If
  this change is incorrect it will cause issue to our automated-testing
  and regression-testing, but it won't affect the real kernel
  functionality.

** Changed in: ubuntu-kernel-tests
     Assignee: (unassigned) => Po-Hsu Lin (cypressyew)

** Changed in: linux (Ubuntu Bionic)
     Assignee: (unassigned) => Po-Hsu Lin (cypressyew)

** Changed in: linux (Ubuntu Bionic)
       Status: New => In Progress

** Changed in: ubuntu-kernel-tests
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1949889

Title:
  Unable to build net/reuseport_bpf and other tests in
  ubuntu_kernel_selftests on Bionic with make command

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1949889/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to