** Description changed: == Impact == - Although we have CONFIG_RTC_HCTOSYS enabled and set CONFIG_RTC_HCTOSYS_DEVICE to "rtc0", system time would only be set if the RTC driver is built-in. This may not be an issue on most amd64 systems because CONFIG_RTC_DRV_CMOS is y for amd64, however it is an issue for other architectures since there may not be a proper RTC driver enabled as built-in. Also make every RTC driver that may be used as built-in is not a good option. + Although we have CONFIG_RTC_HCTOSYS enabled and set CONFIG_RTC_HCTOSYS_DEVICE to "rtc0", system time would only be set if the RTC driver is built-in. This may not be an issue on most amd64 systems because CONFIG_RTC_DRV_CMOS is y for amd64, however it is an issue for other architectures since there may not be a proper RTC driver enabled as built-in. Also making every RTC driver that may be used as built-in is not a good option. == Fix == The commit is in mainline since v5.7: commit f9b2a4d6a5f18e0aaf715206a056565c56889d9f Author: Steve Muckle <smuc...@google.com> Date: Wed Nov 6 11:46:25 2019 -0800 - rtc: class: support hctosys from modular RTC drivers - - Due to distribution constraints it may not be possible to statically - compile the required RTC driver into the kernel. - - Expand RTC_HCTOSYS support to cover all RTC devices (statically compiled - or not) by checking at the end of RTC device registration whether the - time should be synced. - - Signed-off-by: Steve Muckle <smuc...@google.com> - Link: https://lore.kernel.org/r/20191106194625.116692-1-smuc...@google.com - Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> + rtc: class: support hctosys from modular RTC drivers + + Due to distribution constraints it may not be possible to statically + compile the required RTC driver into the kernel. + + Expand RTC_HCTOSYS support to cover all RTC devices (statically compiled + or not) by checking at the end of RTC device registration whether the + time should be synced. + + Signed-off-by: Steve Muckle <smuc...@google.com> + Link: https://lore.kernel.org/r/20191106194625.116692-1-smuc...@google.com + Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> == Risk of Regression == It's a clean cherry-pick for v5.4 and looks straight forward so risk should be low.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1952077 Title: System time doesn't sync with RTC time on boot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1952077/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
