Public bug reported:

check_disk ignores tmpfs filesystems due to an Ubuntu patch
(debian/patches/exclude-tmpfs-squashfs-tracefs.patch) added for LP
#1827159. This is a bad idea.

On my servers, I have a tmpfs mounted at /tmp. Last night, /tmp filled
up on one of them, resulting in significant breakage. My Icinga disk
alerting did not notify me, because it's ignoring all tmpfs filesystems.
I looked to see why and found that ignoring tmpfs is the Icinga default,
so I adjusted that in my configuration. Unfortunately, that still didn't
work. I eventually tracked that down to this patch. Because this tmpfs
exclusion has been hardcoded in, it is impossible for me to override
this decision.

While I think you should simply remove tmpfs from that patch, an
alternative approach would be to move the code lower, after the
arguments have been parsed, and conditionalize it. Something like this:

if (!fs_exclude_list) {
  np_add_name(&fs_exclude_list, "squashfs");
  np_add_name(&fs_exclude_list, "tmpfs");
  np_add_name(&fs_exclude_list, "tracefs");
}
np_add_name(&fs_exclude_list, "iso9660");

Note that iso9660 is outside the conditional and thus always added as
per the upstream behavior. Thus the default behavior would be the same
as now with the patch, but if the user customizes the exclude list with
-X (e.g. in Icinga, or just via the command line), that would be
honored.

** Affects: monitoring-plugins (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1958481

Title:
  check_disk forcibly ignores tmpfs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1958481/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to