Yes, this looks good to me. I've noticed some upstreams have generally tended to delete the type info from the code comments when they add the type parameters to the function args (I suppose to avoid duplication) but for our purposes updating both places is just fine.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967796 Title: FTBFS - must be compatible with Psr\Log\AbstractLogger To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php-klogger/+bug/1967796/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
