Since the libdfx got uploaded a few days ago, I now started to review dfx-mgr, in preparation for it's upload: - changelog: - version is okay(ish, unfortunately upstream does not follow semantic versioning yet: https://semver.org/ - hope we could convince them to do that in future) - codename correct - changelog msg good - changelog incl. reference to LP bug (in correct syntax) - libdfx-mgr1.symbols looks good (w/o any specific version suffix, like XubuntuY) - d/*install files are reasonable - hardening in d/rules, and overrides look good - d/watch is in latest format and good - on patch in d/p/ - looks good (with correct DEP3 header) - d/copyright ok - debian source format 3.0 - zero messages on lintian (-EvIL -pedantic) on src package - packages build successful: https://launchpad.net/~fheimes/+archive/ubuntu/dfx-mgr-test (depending on libdfx, that also built fine) - build log looks fine (no errors or failures) https://launchpadlibrarian.net/715608186/buildlog_ubuntu-noble-arm64.dfx-mgr_2023.2-0ubuntu1_BUILDING.txt.gz - lintian (-EvIL -pedantic) on bin DEBs comes up with 3 warnings about missing man pages; nothing that can be solved on short notice (but worth to mention and ask for upstream) - sanity checks ok
Overall, I think it's ready to be sponsored and uploaded - nice work! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2048462 Title: [needs-packaging] dfx-mgr from Xilinx To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2048462/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
