Hi Paul, I think Benjamin led you astray with this comment:
> 4. 0001-utest-autopkgtest.patch is not needed. You can override it with `make test LIBTRACEEVENT_STATIC="-ltraceevent"` This variable is *not* override-able without your patch -- it will just be assigned unconditionally in the Makefile. When I ran autopkgtest locally with your current patch, it fails: ``` autopkgtest [11:50:49]: test command1: LIBTRACEEVENT_STATIC=$(dpkg -L libtraceevent-dev | grep libtraceevent.so) make test && ./utest/trace-utest autopkgtest [11:50:49]: test command1: [----------------------- DESCEND src libtraceevent.a COMPILE FPIC event-parse-api.o COMPILE FPIC event-parse.o COMPILE FPIC event-plugin.o COMPILE FPIC kbuffer-parse.o COMPILE FPIC parse-filter.o COMPILE FPIC parse-utils.o COMPILE FPIC tep_strerror.o COMPILE FPIC trace-seq.o BUILD STATIC LIB libtraceevent.a ar: /tmp/autopkgtest.1gCwTh/build.6Vd/src/lib/libtraceevent.a: No such file or directory make[1]: *** [Makefile:22: /tmp/autopkgtest.1gCwTh/build.6Vd/src/lib/libtraceevent.a] Error 1 make: *** [Makefile:212: /tmp/autopkgtest.1gCwTh/build.6Vd/src/lib/libtraceevent.a] Error 2 autopkgtest [11:50:51]: test command1: -----------------------] autopkgtest [11:50:52]: test command1: - - - - - - - - - - results - - - - - - - - - - command1 FAIL non-zero exit status 2 autopkgtest [11:50:52]: test command1: - - - - - - - - - - stderr - - - - - - - - - - ar: /tmp/autopkgtest.1gCwTh/build.6Vd/src/lib/libtraceevent.a: No such file or directory make[1]: *** [Makefile:22: /tmp/autopkgtest.1gCwTh/build.6Vd/src/lib/libtraceevent.a] Error 1 make: *** [Makefile:212: /tmp/autopkgtest.1gCwTh/build.6Vd/src/lib/libtraceevent.a] Error 2 ``` Restoring the patch to make LIBTRACEEVENT_STATIC override-able fixes this. One other thing that would be nice, but is not strictly necessary, would be to give the autopkgtest a user-friendly name, e.g. 'trace-utest'. You can do this by adding `Features: test-name=trace-utest` to the appropriate stanza in debian/tests/control. Otherwise, the test is called 'command1', which is fine, but not ideal. I don't think we need to block on upstream, but as Benjamin suggested, please do forward the patches (after fixing the above) to upstream, and add a `Forwarded: <URL to upstream PR>` header to the appropriate patch files. Thanks for your continued effort on this. ** Changed in: libtraceevent (Ubuntu) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055258 Title: No test suite run at built time nor as autopkgtest To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libtraceevent/+bug/2055258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs