** Description changed: - We have recently updated the Pro to not strictly run after cloud- - config.service. If cloud-config.service has not been started when pro - runs, it can complete before cloud-config.service begins and thus the - user-specificed pro configuration will be ignored since the instance is - already attached. + [ Impact ] + If the user has specified custom setup for the Pro client through cloud-init, there is a high chance that this setup will be ignored. + + This happened due to a recent change made on the Pro client. We + identified a race condition when our daemon waited for the cloud-config + service to be finished. We have removed that condition, by manually + checking the cloud-config service state in the daemon itself and only + proceeding if it has already finished. + + However, there is a situation where the cloud-init service has not even + started yet, which would generate a inactive state for the cloud-config + service, allowing our daemon to proceed, causing the problem. + + [Discussion] + + To address that issue, we are now also checking if the cloud-init service + has already started if we detect that cloud-config service is inactive. If it isn't, the daemon will sleep for an specific amount of time before trying again. + + [ Test Plan ] + Since this is a first boot issue, we will need to create a custom image with the package in proposed. Then, we need to guarantee that Pro configuration delivered + through cloud-init is being honored when we launch the image. + + CPC is already aware of this issue and will help us creating the test + plan here. + + [ Where problems could occur ] + We are updating the cloud-init wait logic on the daemon. This could potentially make our daemon to not start. However, since we are just now waiting on the base cloud-init.service to start and we have already tested this solution in a custom image, we believe this is a low risk for this fix. + + [ Original Description ] + We have recently updated the Pro to not strictly run after cloud-config.service. If cloud-config.service has not been started when pro runs, it can complete before cloud-config.service begins and thus the user-specificed pro configuration will be ignored since the instance is already attached. When cloud-config.service has yet to run, ubuntu-advantage.service should wait until it's finished before running.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2059952 Title: pro sometimes runs before cloud-config.service To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs