Hi Sudip, Thanks for debugging, backporting, and submitting a patch! Nice touch on the DEP-3 headers.
Just a style/cosmetic _suggestion_ that is helpful: in the future, please list the .patch file in d/changelog; e.g., '* d/p/fix-segfault.patch: Fix segfault with binhex, frommac and tomac. (LP: #1892558)' And just for documentation purposes: > There is no change in code, only the relevant header file has been included. > And, so there are minimum chances of a regression. The inclusion of a header file even 'without code changes' may actually cause code changes _indirectly_. For example, a header file defines a macro that is checked in the source file (to change code paths) with a preprocessor #if/#ifdef. This is _not_ the case here, as the included headers only define the function prototypes, and nothing else/no macro; so it looks good! I also confirmed that the newer releases have the change and are not affected. Accepting macutils to focal-proposed. Thanks again! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892558 Title: [SRU] binhex always segfaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
