** Description changed:

+ [Impact]
+ needrestart shouldn't be writing to /run/reboot-required for kernel updates, 
that should be reserved to update-manager
+ 
+ [Test plan]
+ 
+ We can use the mockuname thing from the autopkgtests to simulate a kernel
+ version mismatch:
+ 
+ pull-lp-source needrestart noble
+ cd noble-3.6
+ gcc -shared -fPIC -ldl debian/tests/mockuname.c -o mockuname.so
+ LD_PRELOAD=$PWD/mockuname.so apt install hello
+ # needrestart should complain that the system should be restarted
+ test ! -x /run/reboot-required || echo test failed
+ 
+ [Where problems could occur]
+ 
+ That particular patch seems on the safer side, nothing in the code
+ relies on this file being written to.
+ 
+ [Original report]
+ 
  On Noble, I see this in my motd:
  
  *** System restart required ***
  Pending kernel upgrade!
  Running kernel version:
-   6.8.0-22-generic
+   6.8.0-22-generic
  Diagnostics:
-   The currently running kernel version is not the expected kernel version 
6.8.0-31-generic.
+   The currently running kernel version is not the expected kernel version 
6.8.0-31-generic.
  
  I found this code in needrestart:
  
  /usr/sbin/needrestart:                              'The currently
  running kernel version is {kversion} which is not the expected kernel
  version {eversion}.',
  
  I'm told that it is incorrect for needrestart to be injecting this into
  motd. Steve points out that needrestart isn't installed on desktop and
  the behaviour shouldn't be different here, thinks that this shouldn't be
  injected into motd, and asked for a bug report for this.
  
  needrestart     3.6-7ubuntu4

** Description changed:

  [Impact]
  needrestart shouldn't be writing to /run/reboot-required for kernel updates, 
that should be reserved to update-manager
  
  [Test plan]
  
  We can use the mockuname thing from the autopkgtests to simulate a kernel
  version mismatch:
  
  pull-lp-source needrestart noble
- cd noble-3.6
+ cd needrestart-3.6
  gcc -shared -fPIC -ldl debian/tests/mockuname.c -o mockuname.so
  LD_PRELOAD=$PWD/mockuname.so apt install hello
  # needrestart should complain that the system should be restarted
  test ! -x /run/reboot-required || echo test failed
  
  [Where problems could occur]
  
  That particular patch seems on the safer side, nothing in the code
  relies on this file being written to.
  
  [Original report]
  
  On Noble, I see this in my motd:
  
  *** System restart required ***
  Pending kernel upgrade!
  Running kernel version:
    6.8.0-22-generic
  Diagnostics:
    The currently running kernel version is not the expected kernel version 
6.8.0-31-generic.
  
  I found this code in needrestart:
  
  /usr/sbin/needrestart:                              'The currently
  running kernel version is {kversion} which is not the expected kernel
  version {eversion}.',
  
  I'm told that it is incorrect for needrestart to be injecting this into
  motd. Steve points out that needrestart isn't installed on desktop and
  the behaviour shouldn't be different here, thinks that this shouldn't be
  injected into motd, and asked for a bug report for this.
  
  needrestart     3.6-7ubuntu4

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2065863

Title:
  needrestart causes kernel upgrade messages in motd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2065863/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to