Thank you for the update!
> ...but still needs to grab the python version for internal functions.
I guess this is:
> ++ elif sys.version_info[:2] == (3, 12):
> ++ from DisplayCAL.lib64.python312.RealDisplaySizeMM import *
I'm not happy about this. If the CPython API doesn't change, then the
package should correctly be able to rebuild against a newer Python
without needing any changes to the source tree. Every other Python
extension package achieves this and I see no exceptional reason why this
cannot be done here. But I looked at the details and it seems like it'd
be too invasive to do in an SRU (setup.py seems unnecessarily complex
and seems to have the effect of removing this functionality that we'd
get for free from something simpler), so I'll accept as-is.
It'd be nice to file a bug upstream asking for this quality issue to be
fixed, though, and or fixing it upstream and/or the development release.
> @@ -526,7 +532,7 @@ dispcalgui (1.0.7.6-1) unstable; urgency=low
> (Closes: #675680).
> * Don't package uneeded /etc/udev directory.
> * Of course, should depends on argyll.
> - *
> + *
>
> -- Christian Marillat <maril...@debian.org> Sun, 24 Jun 2012 11:02:13 +0200
Random whitespace error? Seems not worth holding this SRU up further
just for this though.
> However, as stated in the description, I argue that having a
functioning application is better than a flaky test that crashes the
entire application. As far as I can see, the application functions
normally without the test.
OK, trade-off accepted. Thank you for documenting this reasoning!
> +-py_minversion = (3, 8)
> +-py_maxversion = (3, 11)
FWIW, I'd have made this patch more minimal and removed or disabled the
final check only. That would make future conflicts less likely and
easier to resolve. Maintainability for distro patches is quite different
from what would be most maintainable upstream!
** Changed in: displaycal-py3 (Ubuntu Noble)
Status: In Progress => Fix Committed
** Tags added: verification-needed verification-needed-noble
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2061329
Title:
[SRU] displaycal 3.9.11-2 needs patch to work with Python 3.12
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/displaycal-py3/+bug/2061329/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
