Review for Source Package: jpeg-xl [Summary]
Package looks good. There's a bug in debian about FTBFS on riscv64 but does not affect ubuntu. MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs. This does need a security review, so I'll assign ubuntu-security List of specific binary packages to be promoted to main: jpeg-xl-doc,libjxl-dev,libjxl-gdk-pixbuf,libjxl0 Specific binary packages built, but NOT to be promoted to main: libjpegxl-java,libjpegli-tools,libjxl-devtool,libjxl-tools Required TODOs: 1. highway needs to be promoted before this one https://bugs.launchpad.net/ubuntu/+source/highway/+bug/2070807 - The package should get a team bug subscriber before being promoted [Rationale, Duplication and Ownership] There is no other package in main providing the same functionality. A team (~desktop-packages) is committed to own long term maintenance of this package. The rationale given in the report seems valid and useful for Ubuntu [Dependencies] OK: - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: - highway needed in main, currenctly under MIR (https://launchpad.net/bugs/2070807) [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have unexpected Built-Using entries - not a go package, no extra constraints to consider in that regard - not a rust package, no extra constraints to consider in that regard - Does not include vendored code Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not expose any external endpoint (port/socket/... or similar) - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) - does not deal with cryptography (en-/decryption, certificates, signing, ...) Problems: - Had a few CVEs in the past - does parse data formats (files [images, video, audio, xml, json, asn.1], network packets, structures, ...) from an untrusted source. [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - does have a non-trivial test suite that runs as autopkgtest - This does not need special HW for build or test - no new python2 dependency Problems: None [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking is in place. - debian/watch is present and looks ok (if needed, e.g. non-native) - Upstream update history is good - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - debian/rules is rather clean - It is not on the lto-disabled list Problems: None [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody - no use of setuid / setgid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit or libseed - not part of the UI for extra checks - no translation present, but none needed for this case Problems: - In debian there's a bug report that it cannot build in riscv64 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1077336) but it builds ok on ubuntu. ** Bug watch added: Debian Bug tracker #1077336 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1077336 ** Changed in: jpeg-xl (Ubuntu) Assignee: Ioanna Alifieraki (joalif) => (unassigned) ** Changed in: jpeg-xl (Ubuntu) Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2070882 Title: [MIR] jpeg-xl To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/jpeg-xl/+bug/2070882/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
