Review for Source Package: libimobiledevice-glue [Summary] MIR team ACK As the package had many CVEs in the past, and as it’s parsing external content fdrom untrusted source, I think we should then ask for a security review. I'll thus assign ubuntu-security. List of specific binary packages to be promoted to main: libimobiledevice-glue-1.0-0, libimobiledevice-glue-dev
[Rationale, Duplication and Ownership] There is no other package in main providing the same functionality. A team is committed to own long term maintenance of this package. The rationale given in the report seems valid and useful for Ubuntu [Dependencies] OK: - no other Dependencies to MIR due to this - libimobiledevice-glue checked with `check-mir` all dependencies can be found in `seeded-in-ubuntu` (already in main) - none of the (potentially auto-generated) dependencies (Depends and Recommends) that are present after build are not in main - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have unexpected Built-Using entries - not a go package, no extra constraints to consider in that regard - not a rust package, no extra constraints to consider in that regard [Security] OK: - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not expose any external endpoint (port/socket/... or similar) - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) - does not deal with cryptography (en-/decryption, certificates, signing, ...) - this makes appropriate (for its exposure) use of established risk mitigation features (dropping permissions, using temporary environments, restricted users/groups, seccomp, systemd isolation features, apparmor, ...) Problems: - Many CVEs in the past. I think we should then ask for a security review, parsing external content fdrom untrusted source [Common blockers] OK: - does not FTBFS currently - does have a non-trivial test suite that runs as autopkgtest - no new python2 dependency Problems: - No package build time testsuite, but autopkgtests one. [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking is in place. - debian/watch is present and looks ok - Upstream update history is good - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far - no massive Lintian warnings - debian/rules is rather clean - It is not on the lto-disabled list [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody (consider at least `grep -Hrn nobody` for it and run `find . -user nobody` in source and built binaries) - no use of setuid / setgid (consider at least `grep -Hrn -e setuid -e setgid` for it and run `find . \( -perm -4000 -o -perm -2000 \)` in source and built binaries) - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit or libseed - not part of the UI for extra checks - no translation present, but none needed for this case ** Changed in: libimobiledevice-glue (Ubuntu) Assignee: Didier Roche-Tolomelli (didrocks) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2074086 Title: MIR libimobiledevice-glue To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libimobiledevice-glue/+bug/2074086/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs