Packaging review[1]
MUST:
- Package must meet Ubuntu versioning & Maintainer requirements
4.2.1-0ubuntu4, OK
Package targets oracular, should target Plucky.
As the package a new one, we can consolidate the changelog
(as it currently references packages never uploaded to the archive)
- Package must match current Ubuntu (and Debian) packaging policies
Lintian warnings:
W: pwl-fwupdate-service: unknown-field Modaliases
W: pwl-fwupdate-service-dbgsym: unknown-field Modaliases
W: pwl-madpt-service: unknown-field Modaliases
W: pwl-madpt-service-dbgsym: unknown-field Modaliases
W: pwl-pref-service: unknown-field Modaliases
W: pwl-pref-service-dbgsym: unknown-field Modaliases
W: pwl-test-quick-suspend-resume: unknown-field Modaliases
W: pwl-unlock-service: unknown-field Modaliases
Those are produced by dh_modalias and can be suppressed.
debian/source/include-binaries - not needed
- Package must build, install, run, remove, and purge cleanly
OK, did not check running as I lack the hardware.
Is it possible to provide a test plan?
SHOULD:
- Package should be lintian clean
NOK, Produces lintian warnings, see above
- Contents of debian/ should be sane
debian/pwl-test-quick-suspend-resume.{preinst,postrm} - we can just do
rm -f without if condition
- Changelog should close a "needs-packaging" bug
OK
- Package should follow http://www.debian.org/doc/manuals/developers-
reference/best-pkging-practices.html
Package needs a manual page
Nit: we can use cmake buildsystem:
%:
dh $@ --with modaliases --buildsystem cmake --builddir=build
override_dh_auto_configure:
dh_auto_configure -- --install-prefix="/temp"
override_dh_auto_install:
dh_auto_install
mv $(CURDIR)/debian/tmp/temp/* $(CURDIR)/debian/tmp
rm -rf $(CURDIR)/debian/tmp/temp/
override_dh_installsystemd:
dh_installsystemd -ppwl-core-service --name=pwl_core pwl-core.service
dh_installsystemd -ppwl-fwupdate-service --name=pwl_fwupdate
pwl-fwupdate.service
dh_installsystemd -ppwl-madpt-service --name=pwl_madpt pwl-madpt.service
dh_installsystemd -ppwl-pref-service --name=pwl_pref pwl-pref.service
Maintenance review
MUST:
- Package must contain a watch file or get-orig-source rule
OK
- If upstream is no more, the packager should consider adopting the upstream
package somewhere
n/a
- Packages who implement get-orig-source for packages with watch files get
extra points
n/a
- Packaged version must not have any known security or critical bugs
n/a
SHOULD:
- Packaging scripts should be readable and readily comprehensible
OK
- Upstream should be responsive, and maintain a bug tracker
https://github.com/palcomwireless/linux_pkgs/issues
- Packaged version should be latest upstream
NOK, 4.2.2 is latest upstream
- Package should not be native without an approved spec
n/a
Suitability review
MUST:
- Package must meet copyright / licensing requirements
Multiverse package,
- Non-native packages must have verifiable cryptographic path to upstream source
Upstream signs commits, we can validate those
- Package must be advocated by at least two members of ubuntu-dev (the packager
may count as one)
OK
SHOULD:
- Package should work on a standard Ubuntu/Kubuntu/Xubuntu/etc. system
Needs testing with real hardware
- Package should provide hints to system services (app-install-data, menus,
etc.) to ease installation and use
OK
- Package should provide Ubuntu-specific documentation for variances in
behaviour from upstream
n/a, no changes vs. upstream
- Package should provide a Homepage: header in debian/control
OK, https://github.com/palcomwireless/linux_pkgs
[1] https://wiki.ubuntu.com/UbuntuDevelopment/CodeReviews#NewPackage
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2084776
Title:
[needs-packaging] pwl-pc-services: Support for Palcom Wireless WWAN
modules
To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/2084776/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
