Joshua,
Some notes about your debdiffs:
- each patch has a trailing whitespace at the start of empty lines, and I had
to remove them all. Your text editor is configured wrong, and you need to adjust
it. The git diff should have no red spaces anywhere.
- I usually like naming the patch lp<number>-<git subject>, e.g.
lp2077348-fix-loadbalancer-stuck-in-cascade-delete.patch. For multiple patches
I usually like
lp2077348-1-fix-blah.patch, lp2077348-2-fix-blah.patch etc.
- The debian changelog needs to have an actual description in it. Simply having
the patch name is not enough. I usually like the format of:
* Description, a few sentences. (LP: #BUG)
- d/p/patch1
- d/p/patch2.
For example, the final one I used was:
* Fix loadbalancer stuck in PENDING_DELETE in cascade delete
with TERMINATED_HTTPS listener if TLS storage not available.
(LP: #2077348)
- d/p/lp2077348-fix-loadbalancer-stuck-in-cascade-delete.patch
- You can use raw git diffs in the patch, but I usually like making them seem
like they are properly dep3 tagged. An example of what I did is here:
https://git.launchpad.net/~mruffell/ubuntu/+source/octavia/tree/debian/patches/lp2077348-fix-
loadbalancer-stuck-in-cascade-delete.patch?h=stable/2024.1
See how I moved the dep3 tags to the bottom, used the git description as the
Subject Line, spaced 1 whitespace in, and made it a little neater.
Your SRU template is okay, but you really need to consider adding to the
"Where problems could occur" section. You need to consider the impact to users
when / if a regression were to occur, and what workarounds a user might use.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2077348
Title:
[SRU] Loadbalacer stuck in status PENDING_DELETE if TLS storage
unavailable in cascade deletion
To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/2077348/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
