The patches all look reasonable, and are correctly annotated with the upstream origins, which is great. My only concern is the SRU template: the test plan is relatively complex to carry out and the regression potential doesn't really cover the full array of possibilities, to my eyes. Just about any update, regardless of how official or minor it is, has the potential to break a package, and this section is currently just covering what the patches affect without considering the potential for wider consequences.
Still, I think there are mitigating factors here: sosreport is kept up to date across all series, so (other than focal which has one extra change) this is the same change, applied to the same version in all series (the extra change in focal is for the autopkgtests and therefore doesn't affect the operation of the package on a user's machine). The test plan could likewise be mitigated by simply linking to the sosreport updates [1] page, used for existing SRUs (this may not be a full version-bump SRU, but it is still an SRU so that page arguably applies). Anyway, I'll leave it to the reporter to decide whether to bulk out those sections a bit, but I'm happy to sponsor for the various series. [1]: https://wiki.ubuntu.com/SosreportUpdates -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2101134 Title: [sru] Obfuscation/Collection issues in sosreport/sos 4.8.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sos/+bug/2101134/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
