Hi Wesley, This has been sponsored to jammy.
Some feedback: This is all very good for your first SRU. Attached is the final debdiff that I sponsored, so you can study it. Notes: - We want to try keep patch file names for what their original commit name was, so I renamed the patch back to lp2106434-pkcs11-tool-load-legacy-provider-for-RIPEMD160.patch - I refreshed the patch with "quilt refresh". - I added commit information to the patch, and added a note about your backport to the Subject tag. - I used the shortened https://bugs.launchpad.net/bugs/2106434 for Bug-Ubuntu. - I changed your debian/changelog entry to better describe what the change actually does, I hope you don't mind. * Include the openssl legacy provider in pkcs11-tool to support RIPEMD160 in openssl 3.0 in jammy. (LP: #2106434) - d/p/lp2106434-pkcs11-tool-load-legacy-provider-for-RIPEMD160.patch I also moved the patch to the final line of the changelog entry. The version was correct, all good there. You can see I edited your SRU template a bit, namely in the testcase section. I usually think its better to just give all the necessary commands to test things, since if someone decides to run through things, they can just run them instead of digging through pages of documentation. Your testcase was really good though. I eventually got cloud-init working with a new user-data and could reproduce the problem, great job. The test packages work great too. It built successfully in -updates, -proposed with all arches enabled, and the autopkgtests all pass. So sponsored, well done! ** Patch added: "Final debdiff for opensc on jammy" https://bugs.launchpad.net/ubuntu/+source/opensc/+bug/2106434/+attachment/5872322/+files/lp2106434_jammy.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2106434 Title: pkcs11-tool 0.22.0 fails in C_DigestInit with CKR_GENERAL_ERROR To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opensc/+bug/2106434/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
