> The patch only modifies what happens when invoking an action from the tray icons in update-notifier. The "cache out-of-date" tray icon seems to be the only user of this function.
Looking at the code, it is not obvious to me that this is true. The code affected by the patch here is in the invoke() function. That function is called from several callbacks within update.c: cb_action(), cb_preferences(), gtk_status_icon_click_activate_cb(). The cb_action() callback appears to be used more on systems where synaptic is installed, because update_trayicon_create_menu() will add more menu items depending on the existence of /usr/share/applications/synaptic.desktop as per the 'actions' table. Hence, it seems that the regression potential and testing needs to consider how this might impact systems where synaptic is installed (e.g. the flavors of Ubuntu which include synaptic by default), or when code paths besides "cache out-of-date" are taken. Or, if I am misunderstanding the code, and there is a reason why your original claim is correct, please elaborate to make that more clear. Finally, it seems worthwhile to perform the proposed test plan on X11, too, since presumably the modified code path is important on those systems. While unlikely, there is regression potential if the `if (GDK_IS_X11_DISPLAY (gdk_display_get_default ())` condition does not work as expected. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2103445 Title: Clicking 'Show updates' on the app indicator does not work To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/2103445/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
