Thanks for the patches, @pponnuvel! A few comments below, before this is
ready for upload.
In the debian/changelog entry, please explicitly call out the files
you've modified under the `debian/` folder. For this change, this should
be the new patch file you've added under
`debian/patches/bug2110614.patch`.
On the DEP-3 headers:
- the "Author:" tag should not mention you as this is not your original patch.
Given the upstream repo has a COPYRIGHT file and this is a contribution from
the upstream ksh maintainer, it should be "Martijn Dekker <mart...@inlv.org>"
- the "Origin:" tag is missing the upstream URL
On the actual patch contents, there are some unnecessary changes in the
upstream commit. I don't think we need the changes to the NEWS file, so
that hunk can be safely dropped. And although including tests for a
change is always nice, it doesn't seem that in this specific instance
attributes.sh and functions.sh will be run in the Ubuntu packages at
all: debian/tests/control and debian/tests/run.sh only execute the
"basic.sh" test, and debian/control does not invoke the package's test
suite either. We should probably drop those two files from the debdiff,
as well.
Once those points are addressed, we can proceed with sponsoring!
** Changed in: ksh93u+m (Ubuntu Jammy)
Status: Triaged => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2110614
Title:
[SRU] Honour attributes for local assignments in subshells
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2110614/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
