Hi Wesley, Your SRU template is good, and the patch format is okay.
I have one minor nitpick though, the patch name. 0005-Fix-wrong-shebang-of-loguserdata.py.patch I really do prefer if this had lp2116890 at the beginning, like: lp2116890-Fix-wrong-shebang-of-loguserdata.py.patch or maybe even swap the dot to a dash -, e.g. lp2116890-Fix-wrong-shebang-of-loguserdata-py.patch In the future, can you also please tag your bugs as sts. I know it technically isn't used anymore, but it really does give easy access to most of SEG's work. I think its good to also link a ppa where test packages are available, as it shows the package builds, and I can see debdiffs in there as well. It also helps community users who may be affected by the bug to have something to test as well. I also think its helpful to put the actual git commit in the SRU template, usually in the [Other info] section for userspace packages, or the [Fix] section for Kernel SRUs. e.g. [Other info] This was fixed in heat 23.0.0.0rc1 by: commit 29a594c85a7734eefd0cfa635d8fcfca8f9eb60f From: Takashi Kajinami <[email protected]> Date: Wed, 17 Apr 2024 20:08:28 +0900 Subject: Fix wrong shebang of loguserdata.py Link: https://opendev.org/openstack/heat/commit/29a594c85a7734eefd0cfa635d8fcfca8f9eb60f You can also use the [Other info] section for links, mailing list discussions, merge request links etc. PS, you don't need spaces in [Impact] etc. Would you like to fix up your merge request to ~ubuntu-openstack- dev/ubuntu/+source/heat:stable/2024.1? Well done on following the cloud SRU documentation. Thanks, Matthew -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2116890 Title: Incorrect shebang in loguserdata.py To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/2116890/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
