It looks like the various comments from reviewers have been addressed, so I've tried to review this to sponsor for plucky and noble. As a debdiff this is extremely hard to review (probably would've been better as an MP against the relevant git-ubuntu branches), but after importing to a local git repo I managed to determine the similarity of the changes uploaded for questing. Hence, I'm sponsoring for plucky and noble.
That said, after performing a local test-build, there were several lintian errors which ought to be addressed (in questing at the least): E: wsl-pro-service: aliased-location [lib/] E: wsl-pro-service: aliased-location [lib/systemd/] E: wsl-pro-service: aliased-location [lib/systemd/system/] E: wsl-pro-service: aliased-location [lib/systemd/system/wsl-pro.service] Specifically, the way d/rules is installed the systemd service is not ideal: use dh_installsystemd in an override_dh_installsystemd section instead (this will ensure that things are started/stopped/enabled/disabled correctly, and also that the correct path of usr/lib is used instead of lib). E: wsl-pro-service source: missing-notice-file-for-apache-license [vendor/google.golang.org/grpc/NOTICE.txt] E: wsl-pro-service source: missing-notice-file-for-apache-license [vendor/gopkg.in/yaml.v3/NOTICE] It looks as though these NOTICE files ought be included in debian/docs to ensure they're included in the binary package (I'm not entirely sure why, given d/copyright does specify these packages are indeed Apache 2.0 licensed, so this is essentially redundant -- maybe these are false- positives? In that case these should be overridden in d/wsl-pro- service.lintian-overrides). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2106757 Title: [SRU] wsl-pro-service version 0.1.18 for Questing, Plucky, Oracular and Noble To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wsl-pro-service/+bug/2106757/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
